From: Jens Axboe <axboe@kernel.dk>
To: Wouter Verhelst <w@uter.be>, Josef Bacik <josef@toxicpanda.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] nbd: correct the maximum value for discard sectors
Date: Fri, 9 Aug 2024 09:34:55 -0600 [thread overview]
Message-ID: <584a1774-0268-4b3c-9a78-0f00073b9d74@kernel.dk> (raw)
In-Reply-To: <20240808070604.179799-3-w@uter.be>
On 8/8/24 1:06 AM, Wouter Verhelst wrote:
> The version of the NBD protocol implemented by the kernel driver
> currently has a 32 bit field for length values. As the NBD protocol uses
> bytes as a unit of length, length values larger than 2^32 bytes cannot
> be expressed.
>
> Update the max_hw_discard_sectors field to match that.
>
> Signed-off-by: Wouter Verhelst <w@uter.be>
> Fixes: 268283244c0f018dec8bf4a9c69ce50684561f46
This isn't the correct way to have a fixes line.
In general, please don't nest next versions under the previous posting,
and it's strongly recommended to have a cover letter that includes that
changed from version N to N+1. Otherwise we have to guess... So please
include that when posting v4.
--
Jens Axboe
next prev parent reply other threads:[~2024-08-09 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 13:04 [PATCH 1/2] nbd: implement the WRITE_ZEROES command Wouter Verhelst
2024-08-03 13:04 ` [PATCH 2/2] nbd: nbd_bg_flags_show: add NBD_FLAG_ROTATIONAL Wouter Verhelst
2024-08-05 12:52 ` [PATCH 1/2] nbd: implement the WRITE_ZEROES command Eric Blake
2024-08-06 7:49 ` Wouter Verhelst
2024-08-06 13:30 ` [PATCH v2 1/3] " Wouter Verhelst
2024-08-06 13:30 ` [PATCH v2 2/3] nbd: nbd_bg_flags_show: add NBD_FLAG_ROTATIONAL Wouter Verhelst
2024-08-06 13:30 ` [PATCH v2 3/3] nbd: correct the maximum value for discard sectors Wouter Verhelst
2024-08-07 13:56 ` Josef Bacik
2024-08-07 17:20 ` Damien Le Moal
2024-08-08 6:55 ` Wouter Verhelst
2024-08-08 7:06 ` [PATCH v3 1/3] nbd: implement the WRITE_ZEROES command Wouter Verhelst
2024-08-08 7:06 ` [PATCH v3 2/3] nbd: nbd_bg_flags_show: add NBD_FLAG_ROTATIONAL Wouter Verhelst
2024-08-08 7:06 ` [PATCH v3 3/3] nbd: correct the maximum value for discard sectors Wouter Verhelst
2024-08-09 15:22 ` Damien Le Moal
2024-08-09 15:34 ` Jens Axboe [this message]
2024-08-12 13:20 ` Wouter Verhelst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584a1774-0268-4b3c-9a78-0f00073b9d74@kernel.dk \
--to=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®