From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AACC77B7C for ; Wed, 24 May 2023 16:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233628AbjEXQ7l (ORCPT ); Wed, 24 May 2023 12:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbjEXQ7i (ORCPT ); Wed, 24 May 2023 12:59:38 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49959E9; Wed, 24 May 2023 09:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vKojb+lmgQ6/iIULJ2na4xC8cdrCol3xSR+2MNG+xDg=; b=BEts6+pXn8xYxsw58Ey/5mU5TL Mum+cwYx+VnKSayyJmO/lKEgzySACtSkoBrGkv/Anh0gNKoi08qhWGyEyLwseWJOe4V99jDZ5d8E6 ivrLMjeg9M9itNhXoYfXYtxxsc/ODmkT+F6zAYowRfyOhQqsIaHF/ODNgIFLQnd6BJes=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q1rpg-00Doak-OI; Wed, 24 May 2023 18:59:28 +0200 Date: Wed, 24 May 2023 18:59:28 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" Subject: Re: [PATCH net-next v1 4/5] net: dsa: microchip: ksz8: Prepare ksz8863_smi for regmap register access validation Message-ID: <584bb123-28c7-4d56-bad7-efcc2c343ecb@lunn.ch> References: <20230524123220.2481565-1-o.rempel@pengutronix.de> <20230524123220.2481565-5-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524123220.2481565-5-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 02:32:19PM +0200, Oleksij Rempel wrote: > This patch prepares the ksz8863_smi part of ksz8 driver to utilize the > regmap register access validation feature. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/microchip/ksz8863_smi.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/dsa/microchip/ksz8863_smi.c b/drivers/net/dsa/microchip/ksz8863_smi.c > index 2af807db0b45..303a4707c759 100644 > --- a/drivers/net/dsa/microchip/ksz8863_smi.c > +++ b/drivers/net/dsa/microchip/ksz8863_smi.c > @@ -104,6 +104,7 @@ static const struct regmap_config ksz8863_regmap_config[] = { > .cache_type = REGCACHE_NONE, > .lock = ksz_regmap_lock, > .unlock = ksz_regmap_unlock, > + .max_register = BIT(8) - 1, Maybe SZ_256 - 1 is more readable? > }, > { > .name = "#16", > @@ -113,6 +114,7 @@ static const struct regmap_config ksz8863_regmap_config[] = { > .cache_type = REGCACHE_NONE, > .lock = ksz_regmap_lock, > .unlock = ksz_regmap_unlock, > + .max_register = BIT(8) - 2, - 2? Is this the 16 bit regmap? So it has 1/2 the number of registers of the 8 bit regmap? So i would of thought it should be BIT(7)-1, or SZ_128-1 ? Andrew