From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA41CA9EAF for ; Mon, 21 Oct 2019 15:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46CFF20700 for ; Mon, 21 Oct 2019 15:36:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="WIUS1x3g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729499AbfJUPgT (ORCPT ); Mon, 21 Oct 2019 11:36:19 -0400 Received: from mail-eopbgr710088.outbound.protection.outlook.com ([40.107.71.88]:6560 "EHLO NAM05-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727607AbfJUPgS (ORCPT ); Mon, 21 Oct 2019 11:36:18 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxFaZHbMC90CstmciEZf3trQm4ZmmdloAL/HWTrmFfvrSdit7uR6T/NvvUUdi97ofOMpyM4Aiuk0SZcwLiunpW/t6I/RXz8M7NBsAig+oU3/Z13eN9ZV0Cq9Rb0DBQCuCr5cSTjfF3fXimdkyAkDXYlLckhF0wKC8iZwMGRqujph4d8wrSwKxRueEbS7mFu92uQLL/zSs45RHkj2MNHTgIbn/S7c5Ip0iDTn3nVFJO4GvlQmFukeyRFTo7V7lD6WPjUUZKazo55+7Rj/p2a4kTPVrf+YWRgFrg8O1Igveaq1mFCgu2yP/GvIfDns80YUjx/CK+aIllyW8Mug+01mrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uB4kB0h6Q/Htk17ng9863atTIxagd5sf9KyLxae2mSI=; b=oNCg3/nzNGj3O16kXk9blNUnmBYAcq7rRsaBgpBKMmGJDpG6XgbOQBPU6TXdFXSg2ZxXDXAgaMTz11I/YN/gR5vv8G83H5yWBnXz5Our634gKKRVM0I2xxYs6VHB27HG8w80Q6HvG85hk3mpkEDWrTu0yiKu8eyEgVIY2AcVaT2GQtwdvVlxOuoiFEMR21+JMgLzDJyhC3MCAloryJEC3+OaSb+NrK0E3djp4TBXxkMDr7J4xt90bRXH5IXCYawYvLqAtR9rMKnDGi3pF4F97YynrXQymgxqw4UIGic8W3rqkWQhuXF1Z+oMfdZf8JOR2iFill4krkODwZgiN0z2qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uB4kB0h6Q/Htk17ng9863atTIxagd5sf9KyLxae2mSI=; b=WIUS1x3gyCFwFB5inXKKeJUbW9Z71MsEPO8bKYlDItfU3J6ryjN4DjIW4+MzTbKr+z7xX/Vl9jcj/VcpxBmGTZjNJgts3JejNL2MEwI5E87WXGLHihltxw/K6saPyPSJPcQ8oa3FaylFUh0GdipkYTH6sOxoxkHGDTkbLzzd0p0= Received: from CY4PR1201MB0230.namprd12.prod.outlook.com (10.172.79.7) by CY4PR1201MB2551.namprd12.prod.outlook.com (10.172.120.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Mon, 21 Oct 2019 15:35:36 +0000 Received: from CY4PR1201MB0230.namprd12.prod.outlook.com ([fe80::5471:f58b:733e:1a61]) by CY4PR1201MB0230.namprd12.prod.outlook.com ([fe80::5471:f58b:733e:1a61%7]) with mapi id 15.20.2347.029; Mon, 21 Oct 2019 15:35:36 +0000 From: Harry Wentland To: "Siqueira, Rodrigo" , "Wentland, Harry" , "Li, Sun peng (Leo)" , "Deucher, Alexander" , "Cornij, Nikola" , Jani Nikula , Manasi Navare , =?Windows-1252?Q?Ville_Syrj=E4l=E4?= , Rodrigo Siqueira CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" Subject: Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition Thread-Topic: [PATCH] drm: Fix DSC throughput mode 0 mask definition Thread-Index: AQHViCDBGBjd4qRZ6EarWeAe3wdSv6dlOhSA Date: Mon, 21 Oct 2019 15:35:36 +0000 Message-ID: <584f5292-c177-34d8-8e2f-0e6661a87f23@amd.com> References: <20191021150345.igdye4kv35nsk4ox@outlook.office365.com> In-Reply-To: <20191021150345.igdye4kv35nsk4ox@outlook.office365.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [165.204.55.250] user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 x-clientproxiedby: YTBPR01CA0035.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::48) To CY4PR1201MB0230.namprd12.prod.outlook.com (2603:10b6:910:1e::7) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Harry.Wentland@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84934dda-0919-447e-f0b4-08d7563c516c x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: CY4PR1201MB2551: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-forefront-prvs: 0197AFBD92 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(7736002)(54906003)(8676002)(5660300002)(6116002)(229853002)(2906002)(6246003)(305945005)(110136005)(66574012)(25786009)(6436002)(6486002)(36756003)(4326008)(256004)(14444005)(6512007)(99936001)(3846002)(186003)(31696002)(52116002)(14454004)(4001150100001)(99286004)(8936002)(81156014)(66476007)(476003)(486006)(478600001)(31686004)(102836004)(66066001)(65806001)(65956001)(316002)(66446008)(64756008)(26005)(71190400001)(71200400001)(58126008)(76176011)(53546011)(2616005)(11346002)(446003)(66616009)(386003)(66946007)(66556008)(81166006)(6506007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB2551;H:CY4PR1201MB0230.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iMdJ8YrFTTN6V1C5HKr+wHc9DxwHbokCIRBIm64zkF7LfE39wUPwNlY4R97+5B2we5dEQRt3kHCglyQmaFnwUZAAczCJG4DkzST3dHT8FIek9ckixbtG5QXoiX8kwzEu5pgfrmqrbE2km+rsrznpWL3pqMtkEoCwheZIk4lMFKPfhHw8nG9Dnf8PRyBe8GDWUGGd/b5tEL1cYyPsTjhh6L0GvNKUvvutIA63sh1QCPzkaccW3Nj9SXmZkeUP3S/ZS4Q5dDS6nfs0Wkav9I+qym7wUsBnPBF6YMAewPoQ1vB05r38UE5KteB1LmI52izWgk85ruiy4MqimqIHITjZAOZt6sw4oT7IQTvstp10D+SBbdFWhJGCse1inId+7Hl0rn21A7JfcrsRyWaougZJrm87GUwyXzae/DlXIZRvZZaEUXGJWf/rhTBwDGVDoB2B Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5AEnsr0KGpggiNbzF6C8RpBBDmYFBFOo5" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84934dda-0919-447e-f0b4-08d7563c516c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 15:35:36.3083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uQSwjzs7v6ooWwhsyno76jJvIiUUOV7TBHpX+X6rbBQt5QmiGbXvlzz9mXFpfnVvS7tdv3c84y7xXKlIWlgDIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2551 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5AEnsr0KGpggiNbzF6C8RpBBDmYFBFOo5 Content-Type: multipart/mixed; boundary="nJMgTaE3fRVCldVSrzx3nOVyfe3neO6fn" --nJMgTaE3fRVCldVSrzx3nOVyfe3neO6fn Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2019-10-21 11:03 a.m., Siqueira, Rodrigo wrote: > Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170 > which is not aligned with the spec. This commit replace 15 << 4 by > 15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the= > specification. >=20 > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Nikola Cornij > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrj=E4l=E4 > Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput sup= port) > Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Harry > --- > include/drm/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index cfadeeef8492..52024049c59e 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -306,7 +306,7 @@ > # define DP_DSC_THROUGHPUT_MODE_0_900 (12 << 0) > # define DP_DSC_THROUGHPUT_MODE_0_950 (13 << 0) > # define DP_DSC_THROUGHPUT_MODE_0_1000 (14 << 0) > -# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 4) > +# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 0) /* 1.4a */ > # define DP_DSC_THROUGHPUT_MODE_1_MASK (0xf << 4) > # define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 > # define DP_DSC_THROUGHPUT_MODE_1_UPSUPPORTED 0 >=20 --nJMgTaE3fRVCldVSrzx3nOVyfe3neO6fn-- --5AEnsr0KGpggiNbzF6C8RpBBDmYFBFOo5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkiEcMSFhcOGNLtE6LVgVyYwUtuMFAl2t0EUACgkQLVgVyYwU tuON8gf+Mgje6g3E0+fTAj/6T//tK+k2y7tTD/Tast/oj4gw5ZKZzprYVwXqHfGe AeJfwbwFtfGjFt21RU62DxwrgK9jDq8LapcNZLYE2ox3AjHGWL+mImXBCKS1gKmY YlWSt29xA1RI7RD1y3Lo4xSMsstFbpNMP5063sRM5x7J4qUyZSuzTcPVGyYYit5G VQ+Ofd8Vvb84ILbjD5s4eQik2w3C31TLBlMrDnVsr6Ui01pysx/ZsQgUSReIxI2C jAIWDhlG8eKIpsP3Xx+BDpZwAST5n6nD8PLVDHfUcKG3xqkkMeYc7QVvbjEGnf+w UkFpcP9KCK8hvRfh+XS+4AxVUJcCNg== =BQvT -----END PGP SIGNATURE----- --5AEnsr0KGpggiNbzF6C8RpBBDmYFBFOo5--