From: Shuah Khan <skhan@linuxfoundation.org>
To: Roberto Ricci <io@r-ricci.it>
Cc: Thomas Renninger <trenn@suse.com>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4 3/6] cpupower-frequency-info.1: trim trailing whitespace
Date: Tue, 24 Mar 2026 16:09:07 -0600 [thread overview]
Message-ID: <58510baa-243c-429f-8ac7-7e917efdf525@linuxfoundation.org> (raw)
In-Reply-To: <acMKUXmN7BFDjfGu@desktop0a>
On 3/24/26 16:04, Roberto Ricci wrote:
> On 2026-03-24 14:00 -0600, Shuah Khan wrote:
>> On 3/23/26 19:35, Roberto Ricci wrote:
>>> Remove useless spaces at the end of some lines in
>>> cpupower-frequency-info.1.
>>
>> Why are the spaces useless and what happens if you don't
>> remove them?
>
> They seem to be both useless and harmless. With or without trailing
> spaces, the output is identical (tested with both mandoc and groff).
> Since I added the new options by copy-pasting the existing ones and
> changing the text, my patch added lines with trailing whitespace and
> checkpatch.pl complained about this. Removing these spaces from just the
> new lines fixes the error, but I decided to remove them from all the
> lines in the file for consistency.
Right - I ran these through mandoc - Since they don't change anything,
I would rather not take these whitespace removal patches.
Is there a dependency between the whitespace ones and the other patches?
Can you drop the whitespace ones and send me just the fix patches?
thanks,
-- Shuah
next prev parent reply other threads:[~2026-03-24 22:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 1:35 [PATCH v4 0/6] cpupower: fix various man pages issues Roberto Ricci
2026-03-24 1:35 ` [PATCH v4 1/6] cpupower-frequency-set.1: trim trailing whitespace Roberto Ricci
2026-03-24 19:59 ` Shuah Khan
2026-03-24 22:08 ` Roberto Ricci
2026-03-24 1:35 ` [PATCH v4 2/6] cpupower-idle-info.1: fix short option names Roberto Ricci
2026-03-24 1:35 ` [PATCH v4 3/6] cpupower-frequency-info.1: trim trailing whitespace Roberto Ricci
2026-03-24 20:00 ` Shuah Khan
2026-03-24 22:04 ` Roberto Ricci
2026-03-24 22:09 ` Shuah Khan [this message]
2026-03-24 1:35 ` [PATCH v4 4/6] cpupower-frequency-info.1: use the proper name of the --perf option Roberto Ricci
2026-03-24 1:35 ` [PATCH v4 5/6] cpupower-frequency-info.1: document --boost and --epp options Roberto Ricci
2026-03-24 1:35 ` [PATCH v4 6/6] cpupower-info.1: describe the --perf-bias option Roberto Ricci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58510baa-243c-429f-8ac7-7e917efdf525@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=io@r-ricci.it \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®