From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B5CC88CB4 for ; Tue, 13 Jun 2023 11:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242169AbjFMLyR (ORCPT ); Tue, 13 Jun 2023 07:54:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235491AbjFMLyN (ORCPT ); Tue, 13 Jun 2023 07:54:13 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4CF5BA for ; Tue, 13 Jun 2023 04:54:11 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-977d55ac17bso974327966b.3 for ; Tue, 13 Jun 2023 04:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686657250; x=1689249250; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xU6yN1IIA+6UwdBgt828/NiFur95ZAvJWWZKM66bpZA=; b=pbNPJPLJzd+VW9/5QjUJGqDTvRKCjzZjGlpDvWh9kA/5ldR0qhtDppy957c7QfPFqE uBJow20o8qkFP8bUAIaVD5H3iGMX1W1KNiGk08O1IhlrCL+FmXH9tWGniu141rDlrVJT sFpwIkkX3ubwdg8PiVzxPQU3ovJf/xfG/bpwxl24LNBLETWhqNDOwefRM/YON3hLm3lu cnWeadglU0yeqe6KaHluGHj7VUyG/wFsKjXv3sZ2unrbZJn5sUKbhoZO3Dt9lI1BT2Xw ZJlkX0fCXg0eWc+Bt4CheMP0s0zEzzLdVBI53Z6YJskfzO/xxiXCEuDnzuX4rbmulWAu AGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686657250; x=1689249250; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xU6yN1IIA+6UwdBgt828/NiFur95ZAvJWWZKM66bpZA=; b=Eax5Cqa2JfbyRy1IUgbgdLPXQ1IsoRjVE8du0Hf2n8kibXUjPtbrTBm6DKW+QVprE7 9wgsMOgqSaGRC14cZnLNxyzgUm1LFTlubJUT6yGzDcXKKlSIusGjPRSzZ6vdRvUiAqUR ELNVTFYX7gIhfGkRvSbtXkfFMj0CRSHFe+axOsitkE9ZrQ9P2165rSD55w1kzTTnqvik +YQ/boFVstb2OWZVLBYaU/PsM/G+EgtQTHbRYExcWEAfRNRKjFLG61P5ARInOC6MPiYt 7gsMzGukh4wsN2exFaFikfHIr/iIM1PYyzhKySEjFOVXdzRq52Vb2wbfaaY4epLxKfEQ Sp7Q== X-Gm-Message-State: AC+VfDxO+ZTLNfzzwuE82fb8/JROfDGT3KYYd6gFXE5r3XpV7BsW2A/K KmtCT+GdVZx4BGz9jV3JsoZsrQ== X-Google-Smtp-Source: ACHHUZ4Z7G/vVQ715ReLAU2YsEmtH2Yw//I0SbDXHKPqLXwGL9N3doGeITkVAw65IJS9dH2OXCvTTA== X-Received: by 2002:a17:907:e8a:b0:977:c5b1:974b with SMTP id ho10-20020a1709070e8a00b00977c5b1974bmr13452293ejc.34.1686657250305; Tue, 13 Jun 2023 04:54:10 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id rv14-20020a17090710ce00b00977c88d70c6sm6499105ejb.192.2023.06.13.04.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 04:54:09 -0700 (PDT) Message-ID: <5851627e-2972-f860-e965-dc8e73b01225@linaro.org> Date: Tue, 13 Jun 2023 13:54:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 5/8] qcom: pmic_glink: enable altmode for SM8550 Content-Language: en-US To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org References: <20230601-topic-sm8550-upstream-type-c-v3-0-22c9973012b6@linaro.org> <20230601-topic-sm8550-upstream-type-c-v3-5-22c9973012b6@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230601-topic-sm8550-upstream-type-c-v3-5-22c9973012b6@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/2023 09:55, Neil Armstrong wrote: > Altmode is also supported for SM8550, allow it. > > Signed-off-by: Neil Armstrong > --- > drivers/soc/qcom/pmic_glink.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c > index c87056769ebd..8af06bdc6f5a 100644 > --- a/drivers/soc/qcom/pmic_glink.c > +++ b/drivers/soc/qcom/pmic_glink.c > @@ -342,13 +342,9 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT > BIT(PMIC_GLINK_CLIENT_ALTMODE) | > BIT(PMIC_GLINK_CLIENT_UCSI); > > -/* Do not handle altmode for now on those platforms */ > -static const unsigned long pmic_glink_sm8550_client_mask = BIT(PMIC_GLINK_CLIENT_BATT) | > - BIT(PMIC_GLINK_CLIENT_UCSI); > - > static const struct of_device_id pmic_glink_of_match[] = { > { .compatible = "qcom,sm8450-pmic-glink", .data = &pmic_glink_sm8450_client_mask }, Orientation and maybe all of the USB-related properties do not look like sm8450 specific, but PM8350B. That's where CC_OUT pin is. I don't think we represented this correctly, but rather copy-pasted downstream solution... Best regards, Krzysztof