From: Richard Ruigrok <rruigrok@codeaurora.org>
To: Ge Song <ge.song@hxt-semitech.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Make capsules in a contiguous virtual space
Date: Thu, 21 Dec 2017 14:47:13 -0700 [thread overview]
Message-ID: <5851a90c-b334-9b28-d3b3-8eba7c933222@codeaurora.org> (raw)
In-Reply-To: <1513680554-5682-1-git-send-email-ge.song@hxt-semitech.com>
Please tested-by
Tested on Centiq, applied on v4.15-rc4.
This fixes the regression introduced in 4.13 where the capsule is no longer passed in contiguous virtual memory.
On 12/19/2017 3:49 AM, Ge Song wrote:
> Recently we found it failed to update firmware through capsule update
> mechanism in linux-4.14 and later version.
>
> After some investigation, the reason is firmware expects capsules in a
> contiguous virtual space and this assumption is not satisfied in recent
> linux versions.
>
> Ge Song (2):
> Revert "efi/capsule-loader: Use page addresses rather than struct page
> pointers"
> efi/capsule-loader: Request a contiguous virtual space for capsules
>
> drivers/firmware/efi/capsule-loader.c | 23 ++++++++++++++---------
> drivers/firmware/efi/capsule.c | 7 +++----
> include/linux/efi.h | 4 ++--
> 3 files changed, 19 insertions(+), 15 deletions(-)
>
--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-12-21 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:49 Ge Song
2017-12-21 21:47 ` Richard Ruigrok [this message]
2017-12-22 15:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5851a90c-b334-9b28-d3b3-8eba7c933222@codeaurora.org \
--to=rruigrok@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ge.song@hxt-semitech.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®