From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbeAAQyN (ORCPT + 1 other); Mon, 1 Jan 2018 11:54:13 -0500 Received: from mout.web.de ([212.227.15.4]:50579 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbeAAQyL (ORCPT ); Mon, 1 Jan 2018 11:54:11 -0500 To: netdev@vger.kernel.org, Florian Fainelli Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] net: systemport: Delete an error message for a failed memory allocation in two functions Message-ID: <5852a936-de6d-f292-2791-b8469b5f8947@users.sourceforge.net> Date: Mon, 1 Jan 2018 17:54:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:U0oMaRtbVhuIGMyeFhfLXoOQOSd+Cj4pxW+rFZUOzk6PN/0VLml LiRx1AxsXhLNNSumzf+pB7QrJXTcgj/stjm4wX/1Q4Ss+lcBXEhBkDtH2wafZhLeMn/RU3X sqHc6X65U3pH7NwGbMn04FDxTFqSWyUeXSi1nMA4NOjJTj8QZ88rtNzd5vKgifeLikBInML 2K259suDQ8cSHd3uYSUbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:6OwJN1e9AyA=:R3VkJKXxgyE0I6UDg/HkyC v0iM8Ibmv3F2fIoI3kq+v/dmMGNyHfQS8+8BH0lrKNrjKOkdy3HxT110ZvPzFKUxRRdzRIzMG RTs+tqxe/Iv/C/6jNYY4qDnO2ElJwjj2pO7J+m/ci6VCkEb2a0oIV95TgKt/2iyndFz0WYjp3 ubQEcu7A0H6Ure1HtDQCYfkD+rNU9NqAtyOnE/lMFi47ja6nO+Cp3nPJR2Q1wfPs3vI63cgyS lzKoZhA7tKk97nNdT6hP7hadeOd/1ubvN/j+VLbMvBOD4I0uhL8qI0n94CWQA4e+t1VkksTCs IG/FPxgnLYqPnRxlUWZUTXwG4UqXrxKe4bwpcxuQk3twWPnAwFs5xhcc5I/4i2ibJoSJiY20O 4SJeImQsk5TOaPH3G7VBjM2sbJF6f2XE7Sx3f+u3IkTXX5gZRMXzbbu2HXZPT/E9eRh/d4SNU 89OXLTTrHF4BjqrQ3QaqDmMVHtXHLAeemoUC5wdJAEZ529ayE7rHVuAVMJdmEcMoNjHCI8oe4 By+K1pxKXzdFcEFQsc4aqsqlHDR8qkjhXnrPuALwgoc6+PIWoQvjY0xffnu5uQttoCn+nxymn TCUdnwaMToRsG2O7dMW2p6ikaDWi9+SKdGjgZXyeZd5f7tHAYmym+UMFHsQh79NEonxrW6Etl RpwLDKRjXgH5vxttKAtjf8sHkx3g3b6kIoZtIFhbmiEVItJX0lJDzSFfpkHwSz8X5UFDF6lKK nYjxYv93AyT3hn2Lpjedu5wqU4cPZpDe+/yQ7eLie9Lb3sLxY1H447zpRk4LJ3IFiPzDLuYFi QDwtKwB1eVbu3SQuKHFVTsYshcFcLeiuxznc39o80Bqgx3RxPg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Mon, 1 Jan 2018 17:50:02 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/broadcom/bcmsysport.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 9d7a834c5f62..34e6ddde89e1 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -1396,7 +1396,6 @@ static int bcm_sysport_init_tx_ring(struct bcm_sysport_priv *priv, if (!ring->cbs) { dma_free_coherent(kdev, sizeof(struct dma_desc), ring->desc_cpu, ring->desc_dma); - netif_err(priv, hw, priv->netdev, "CB allocation failed\n"); return -ENOMEM; } @@ -1576,10 +1575,8 @@ static int bcm_sysport_init_rx_ring(struct bcm_sysport_priv *priv) priv->rx_read_ptr = 0; priv->rx_cbs = kcalloc(priv->num_rx_bds, sizeof(struct bcm_sysport_cb), GFP_KERNEL); - if (!priv->rx_cbs) { - netif_err(priv, hw, priv->netdev, "CB allocation failed\n"); + if (!priv->rx_cbs) return -ENOMEM; - } for (i = 0; i < priv->num_rx_bds; i++) { cb = priv->rx_cbs + i; -- 2.15.1