From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933688AbcLSRtA (ORCPT ); Mon, 19 Dec 2016 12:49:00 -0500 Received: from smtp105.ord1c.emailsrvr.com ([108.166.43.105]:51676 "EHLO smtp105.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401AbcLSRs5 (ORCPT ); Mon, 19 Dec 2016 12:48:57 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Message-ID: <58581D7D.1030309@mev.co.uk> Date: Mon, 19 Dec 2016 17:48:45 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: devendra sharma CC: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments References: <1482158175-3130-1-git-send-email-devendra.sharma9091@gmail.com> In-Reply-To: <1482158175-3130-1-git-send-email-devendra.sharma9091@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/2016 14:36, devendra sharma wrote: > Added comments before memory barrier > > Signed-off-by: Devendra Sharma > --- > drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c > index c9eb26f..c3b5236 100644 > --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c > +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c > @@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev, > > mutex_lock(&devpriv->mutex); > for (n = 0; n < insn->n; n++) { > + /*multi-processor memory barrier*/ > smp_mb(); Thanks for the effort, but these comments add no useful information and serve only to silence the checkpatch warnings. Also, there is no space after the '/*' and before the '*/'. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-