From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933980AbcLSSNK (ORCPT ); Mon, 19 Dec 2016 13:13:10 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:49914 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbcLSSNI (ORCPT ); Mon, 19 Dec 2016 13:13:08 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Message-ID: <58582328.2070503@mev.co.uk> Date: Mon, 19 Dec 2016 18:12:56 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: devendra sharma CC: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, ansonjacob.aj@gmail.com, amitoj1606@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing References: <1482160468-5614-1-git-send-email-devendra.sharma9091@gmail.com> In-Reply-To: <1482160468-5614-1-git-send-email-devendra.sharma9091@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/2016 15:14, devendra sharma wrote: > Fixed coding issue about multiple line dereferencing > > Signed-off-by: Devendra Sharma > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > I guess this is version 3 of the patch? > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index cb9c269..9ace9c0 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -2475,20 +2475,17 @@ static int setup_channel_queue(struct comedi_device *dev, > /* load external queue */ > for (i = 0; i < cmd->chanlist_len; i++) { > bits = 0; > + unsigned int ch = cmd->chanlist[i]; Please put all declarations within a block before any statements in the block (in other words, avoid mixing declarations with code), and use a blank line to separate the declarations from the statements. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-