From: Bryan O'Donoghue <bod@kernel.org>
To: Anusha Arun Nandi <anusha.nandi@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
gjorgji.rosikopulos@oss.qualcomm.com,
hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com,
jigarkumar.zala@oss.qualcomm.com, linux-phy@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] phy: qcom-mipi-csi2: Add support for single power-domain SoCs
Date: Wed, 28 Oct 2026 09:58:35 +0000 [thread overview]
Message-ID: <58599b61-a56b-4d6b-b09f-03d813a64c1c@kernel.org> (raw)
In-Reply-To: <20261028052047.2738893-1-anusha.nandi@oss.qualcomm.com>
On 28/10/2026 05:20, Anusha Arun Nandi wrote:
> - if (ret < 0 || csi2phy->pd_list == NULL) {
> - if (ret == 0)
> - ret = -ENODEV;
> + if (ret < 0)
> return dev_err_probe(dev, ret, "Failed to attach power-domain list\n");
> - }
Shouldn't this be
if (ret < 0 || ( csi2phy->soc_cfg->num_genpds > 1 && csi2phy->pd_list ==
NULL) {
i.e. you are dropping the NULL check for the case of multiple power-domains.
---
bod
next prev parent reply other threads:[~2026-10-28 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZW6-XDf5dgEFD66QI7ZA8WIK_alWTQD2RWolsXjlSql7pO5IUj9PM1T95LMfBd2Y3zKxRhDXXde1R4asZWzgKw==@protonmail.internalid>
2026-10-28 5:20 ` Anusha Arun Nandi
2026-10-28 9:58 ` Bryan O'Donoghue [this message]
2026-10-28 15:37 ` Frank Li
2026-10-28 5:10 Anusha Arun Nandi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58599b61-a56b-4d6b-b09f-03d813a64c1c@kernel.org \
--to=bod@kernel.org \
--cc=akapatra@quicinc.com \
--cc=anusha.nandi@oss.qualcomm.com \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=hariram.purushothaman@oss.qualcomm.com \
--cc=jigarkumar.zala@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®