From: "J, KEERTHY" <j-keerthy@ti.com>
To: <robh+dt@kernel.org>, <daniel.lezcano@linaro.org>,
<rui.zhang@intel.com>, <amitk@kernel.org>, <kristo@kernel.org>,
<vigneshr@ti.com>, <krzysztof.kozlowski@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation
Date: Mon, 9 May 2022 08:48:12 +0530 [thread overview]
Message-ID: <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com> (raw)
In-Reply-To: <20220427064635.24898-2-j-keerthy@ti.com>
On 4/27/2022 12:16 PM, Keerthy wrote:
> Add VTM bindings documentation. In the Voltage Thermal
> Management Module(VTM), K3 J72XX supplies a voltage
> reference and a temperature sensor feature that are gathered in the band
> gap voltage and temperature sensor (VBGAPTS) module. The band
> gap provides current and voltage reference for its internal
> circuits and other analog IP blocks. The analog-to-digital
> converter (ADC) produces an output value that is proportional
> to the silicon temperature.
Hi krzysztof,
Any comments on this version?
- Keerthy
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> .../bindings/thermal/ti,j72xx-thermal.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> new file mode 100644
> index 000000000000..84b70fb108da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments J72XX VTM (DTS) binding
> +
> +maintainers:
> + - Keerthy <j-keerthy@ti.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,j721e-vtm
> + - ti,j7200-vtm
> +
> + reg:
> + maxItems: 3
> + description:
> + Must be 3, in order to specify three register spaces for VTM cfg1, cfg2
> + and efuse register space.
> +
> + power-domains:
> + maxItems: 1
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> + wkup_vtm0: thermal-sensor@42040000 {
> + compatible = "ti,j721e-vtm";
> + reg = <0x42040000 0x350>,
> + <0x42050000 0x350>,
> + <0x43000300 0x10>;
> + power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + mpu_thermal: mpu-thermal {
> + polling-delay-passive = <250>; /* milliseconds */
> + polling-delay = <500>; /* milliseconds */
> + thermal-sensors = <&wkup_vtm0 0>;
> +
> + trips {
> + mpu_crit: mpu-crit {
> + temperature = <125000>; /* milliCelsius */
> + hysteresis = <2000>; /* milliCelsius */
> + type = "critical";
> + };
> + };
> + };
> +...
next prev parent reply other threads:[~2022-05-09 3:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:46 [PATCH v6 0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-04-27 6:46 ` [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Keerthy
2022-05-03 0:34 ` Rob Herring
2022-05-09 3:18 ` J, KEERTHY [this message]
2022-05-09 6:42 ` Krzysztof Kozlowski
2022-05-11 7:53 ` J, KEERTHY
2022-05-11 8:15 ` Krzysztof Kozlowski
2022-05-11 10:57 ` J, KEERTHY
2022-04-27 6:46 ` [PATCH v6 2/4] arm64: dts: ti: j721e: Add VTM node Keerthy
2022-04-27 6:46 ` [PATCH v6 3/4] arm64: dts: ti: j7200: " Keerthy
2022-04-27 6:46 ` [PATCH v6 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-05-04 8:00 ` Dan Carpenter
2022-05-09 5:20 ` Joe Perches
2022-05-09 3:10 ` J, KEERTHY
2022-05-10 15:25 ` Daniel Lezcano
2022-05-10 17:17 ` J, KEERTHY
2022-05-10 17:38 ` Daniel Lezcano
2022-05-11 4:57 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5859fed0-82b7-95eb-5719-9b0016916c50@ti.com \
--to=j-keerthy@ti.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®