From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbcGSIgP (ORCPT ); Tue, 19 Jul 2016 04:36:15 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59394 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbcGSIgK (ORCPT ); Tue, 19 Jul 2016 04:36:10 -0400 From: Arnd Bergmann To: Hans Verkuil Cc: Mauro Carvalho Chehab , Hans Verkuil , Greg Kroah-Hartman , Kamil Debski , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] [media] cec: add RC_CORE dependency Date: Tue, 19 Jul 2016 10:35:53 +0200 Message-ID: <5861145.2bCA7xogPm@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <578DE51E.8080604@xs4all.nl> References: <20160719081040.2685845-1-arnd@arndb.de> <20160719081040.2685845-2-arnd@arndb.de> <578DE51E.8080604@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BahpJYDdV4UuO2m97GBIxrQSYK7Feyd9ek4bOkd8/5gHMxyuNLC OWtcD+aHZl8bBxz9Q2B3wO4S0JZpzaj04rSmXYy0x2lRcFczJcQkJEFwbj4qXp4VX1jtqJw yqzHoiemc2CL3p9pOrfDsVh4FMgkHnpzeCyKm4VopXo4qqbcjC37Q37LHsXy7BJF1uXn2XC 5lrKU8a7OUqL2N3rwRjnA== X-UI-Out-Filterresults: notjunk:1;V01:K0:C9OiHRcOU3w=:Vd7iArQtMlSwjxJCJCDE9T IjnI+wxXzTpDLeYcaWTtV2AoTOdU8fJiRiAS66JQBuB1K17Aemp3Mhlr6VXGJ4p90fDeKsuKm 91KlFsEnOC1WfvH0nBMEnmSbtRE2eCQSeVL3vh1j1dRnWW3dqzh0PyuxsoJ2fj8AD5w7pjoGv GSbbLSfpcJ0D94Td+kjVYPUgffiiSLwAlfemNB8F+JJQcU5I/hDZjywK3rtRXjTIa2bqhR9bj gQK6nirSuGEA/5joAZyk8ZS5vwhxyTVitW2TwLgjpJPvdGEsITFt/QQ4XAYHH1eg+QETqZr5l xqdPii0cfTBXXV/se9twRtfoiyzdkaGl5h+N5K1Eeun+gLBfyUguruDMH7m33DIFKtGH+j/Xc W02os/AUva4b67hoRO2SPTym1tgtOgxOKQxwXjmB2xJph7c+KbZ1w7sRtQdDn+O9eh1pkhB2o 1EKQTzYWo4OlZd80Dl3GiV5gvSuXEABtZkLi0VSJM4RrA0HdGdhrv7VFkof4h0+prMGGUTzvf fQodRUP8YClxwVga/r5iGJZyXLvV+x7Gc/arOyIgpvaph5YbQm0inW8yhBlKzgCEtYPNNZW6u lHnFJ7zGMP2hmggveDCttJSkIGRHPxdR2eCDJ9iGbpQ816JB7TqKI6ZrvdBd9CuIhLvd8CR4P mS1NESc0xfq1LbqfVNlfQ4XmY1VScXF6RafgU5dA/p6TBo0mgxURe2yccwi/es1Et1f5VMy1Z JqAqB2tCzJIp44p3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 19, 2016 10:30:22 AM CEST Hans Verkuil wrote: > On 07/19/16 10:10, Arnd Bergmann wrote: > > We cannot build the cec driver when the RC core is a module > > and cec is built-in: > > > > drivers/staging/built-in.o: In function `cec_allocate_adapter': > > :(.text+0x134): undefined reference to `rc_allocate_device' > > drivers/staging/built-in.o: In function `cec_register_adapter': > > :(.text+0x304): undefined reference to `rc_register_device' > > > > This adds an explicit dependency to avoid this case. We still > > allow building when CONFIG_RC_CORE is disabled completely, > > as the driver has checks for this case itself. > > This makes no sense: the rc_allocate_device and rc_register_device > are under: > > #if IS_REACHABLE(CONFIG_RC_CORE) > > So it shouldn't be enabled at all, should it? My mistake, I forgot to remove my patch from the backlog after you added 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems"), and I saw that it's still marked as "new" in patchwork with no reply. I'll drop the patch from my local series and won't submit it again, sorry for the mixup. Arnd