From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655AbdCAGX5 (ORCPT ); Wed, 1 Mar 2017 01:23:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:40852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdCAGXu (ORCPT ); Wed, 1 Mar 2017 01:23:50 -0500 Subject: Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code To: Vitaly Kuznetsov , xen-devel@lists.xenproject.org References: <20170224161440.2136-1-vkuznets@redhat.com> <20170224161440.2136-2-vkuznets@redhat.com> Cc: Boris Ostrovsky , x86@kernel.org, Andrew Jones , linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: <58638497-6660-6119-e24d-d2a8b05d99b0@suse.com> Date: Wed, 1 Mar 2017 07:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170224161440.2136-2-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/17 17:14, Vitaly Kuznetsov wrote: > Introduce CONFIG_XEN_PV config option and split enlighten.c into > 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to > not break the build and not make the patch even bigger. > > xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support > future xen_smp_intr_init() split. > > Signed-off-by: Vitaly Kuznetsov Could you please split pure code movement and functional changes into different patches? This would make review much easier. So 1 patch to split up enlightenment.c and at least one patch for the rest of the changes (Kconfig, splitting of x86_hyper_xen, ...). Juergen