From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbcFPOul (ORCPT ); Thu, 16 Jun 2016 10:50:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41983 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbcFPOuj (ORCPT ); Thu, 16 Jun 2016 10:50:39 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <146608853752.5715.2913110713238395465.stgit@warthog.procyon.org.uk> References: <146608853752.5715.2913110713238395465.stgit@warthog.procyon.org.uk> To: jmorris@namei.org Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, torvalds@linux-foundation.org, Dan Carpenter Subject: Re: [PATCH] KEYS: potential uninitialized variable MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5863.1466088637.1@warthog.procyon.org.uk> Date: Thu, 16 Jun 2016 15:50:37 +0100 Message-ID: <5864.1466088637@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 16 Jun 2016 14:50:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > From: Dan Carpenter > > If __key_link_begin() failed then "edit" would be uninitialized. I've > added a check to fix that. > > This allows a random user to crash the kernel, though it's quite difficult > to achieve. There are three ways it can be done as the user would have to > cause an error to occur in __key_link(): > > ... I forgot to mention, this fixes CVE-2016-4470. David