From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbcFBLnE (ORCPT ); Thu, 2 Jun 2016 07:43:04 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:61204 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbcFBLnB (ORCPT ); Thu, 2 Jun 2016 07:43:01 -0400 From: Arnd Bergmann To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 5/8] x86, pkeys: allocation/free syscalls Date: Wed, 01 Jun 2016 22:48:18 +0200 Message-ID: <5864297.Wx4gj9qW7E@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160531152822.FE8D405E@viggo.jf.intel.com> References: <20160531152814.36E0B9EE@viggo.jf.intel.com> <20160531152822.FE8D405E@viggo.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:lCV1/Jm5TjZW5bDWwl7z2BHC9GwVbXiuR9QiDJ6kDrPYyXPkTTs 73xxkS8uYB3o2RnjGaxN5vHVOxIbtpQsWGuoEEiLLHZSFufiEu55p6l+j0iICs+s62UEGyT 8Fu2nVSmLfCuGFjFzGnrKx1ILm3J/XaPPwZFBjHkdpAHoBMP2iqVte1UzSqt1/cxN8KQZY+ ksFgvSgIVTQLb8yXq2CAA== X-UI-Out-Filterresults: notjunk:1;V01:K0:wwYmc0DhpJI=:PSW/Pv/EGy2lHcI3f9v2Cy +TcMI5EQWSe++zfNh7BX3aW3cHRcGleBigtVZkZwe6M+oZZV02JFOZWERcXlpv67gC5t0uiHx 3C2Slcgf6UZ0w3fwCX1Dy4sUtZ5c6UDH1jsZCpMDRRnlir57MPFsVnt8O2hHvZp6FQ4/ZtfHJ F6BMKPmSXSnRKZc3Lv4ptoiNbuswegG6HRspfdChC8YX11qMBkJL1C0f2YI0E+xkVuaWeXM1U kbGbtY7JBE5Jn1ALKckCrlYqroPE/qHNvmQ09rTEgZx0qu3LHr3405sHEy50AaT1v56hUy+yM mu5aVbIguue3/nmMt0a7Hb1ZkKTNaE2HpIeocLWwmuG6zT65fSI1KCJm4o4fha/wXTCk2+Nmj jUkCaQ20UL5e5NO8v1x7mG5CUTi5Ep9O0NrInYEBxKJRGPh+ULnes2ePjk4nyFqlzfGaW6/eu 7ZWyLDy/WoB0GR+T447kvEtatw8x4w0pkF9x/tuHT+BqZ2Yw1+IQBzZoL4C3S/5WiY7AgDE7/ qyJp4jV9P2FzL1LIXUyqadKo4ofQYusJofBZg49HTFu9wVjZQnKjWV9aqRQvkG4iaq2Y77rIY 1E+2/nOl1fsSJrkM+oGifQszps+a+mJKAar3SCzmH2s+gzrm2eBOCvAOdOtqMPc9jRFG4lIVc n64zrxiaao8w5DY29V2XHK4ItgUCJQCrUSuou+X+wGF4YeyLX+CNsXWmpfFwsiBfMZaddaj3j JMd/496MPExXMW7+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 31, 2016 8:28:22 AM CEST Dave Hansen wrote: > diff -puN arch/x86/entry/syscalls/syscall_32.tbl~pkeys-116-syscalls-allocation arch/x86/entry/syscalls/syscall_32.tbl > --- a/arch/x86/entry/syscalls/syscall_32.tbl~pkeys-116-syscalls-allocation 2016-05-31 08:27:49.150115539 -0700 > +++ b/arch/x86/entry/syscalls/syscall_32.tbl 2016-05-31 08:27:49.176116712 -0700 > @@ -387,3 +387,5 @@ > 378 i386 preadv2 sys_preadv2 compat_sys_preadv2 > 379 i386 pwritev2 sys_pwritev2 compat_sys_pwritev2 > 380 i386 pkey_mprotect sys_pkey_mprotect > +381 i386 pkey_alloc sys_pkey_alloc > +382 i386 pkey_free sys_pkey_free > diff -puN arch/x86/entry/syscalls/syscall_64.tbl~pkeys-116-syscalls-allocation arch/x86/entry/syscalls/syscall_64.tbl > --- a/arch/x86/entry/syscalls/syscall_64.tbl~pkeys-116-syscalls-allocation 2016-05-31 08:27:49.152115629 -0700 > +++ b/arch/x86/entry/syscalls/syscall_64.tbl 2016-05-31 08:27:49.177116758 -0700 > @@ -336,6 +336,8 @@ > 327 64 preadv2 sys_preadv2 > 328 64 pwritev2 sys_pwritev2 > 329 common pkey_mprotect sys_pkey_mprotect > +330 common pkey_alloc sys_pkey_alloc > +331 common pkey_free sys_pkey_free > > # > # x32-specific system call numbers start at 512 to avoid cache impact > Could you also add the system call numbers to include/uapi/asm-generic/unistd.h at the same time? Even if the support is x86 specific for the forseeable future, it may be good to reserve the number just in case. The other architecture specific syscall lists are usually left to the individual arch maintainers, most a lot of the newer architectures share this table. Arnd