From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968168AbdAEHb6 (ORCPT ); Thu, 5 Jan 2017 02:31:58 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:40813 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967997AbdAEHbL (ORCPT ); Thu, 5 Jan 2017 02:31:11 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-RL-SENDER: xzy.xu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: xzy.xu@rock-chips.com X-UNIQUE-TAG: <6e4ebd7333184f96501235c9d99d0a21> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style To: Joe Perches , ulf.hansson@linaro.org, jh80.chung@samsung.com References: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> <1483554741.21292.9.camel@perches.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Ziyuan Message-ID: <586DF630.5070104@rock-chips.com> Date: Thu, 5 Jan 2017 15:30:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1483554741.21292.9.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2017 02:32 AM, Joe Perches wrote: > On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote: >> Let's fix the warnings from checkpatch.pl: >> >> - line over 80 characters; >> - block comments should align the * on each Lines; >> - statements not starting on a tabstop. >> >> Signed-off-by: Ziyuan Xu >> --- >> >> drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++---------------- >> 1 file changed, 17 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > [] >> @@ -94,7 +94,8 @@ struct idmac_desc { >> >> __le32 des1; /* Buffer sizes */ >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff))) >> + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \ >> + (cpu_to_le32((s) & 0x1fff))) > Please look to improve code rather than just shut up > the brainless checkpatch script. > > If this is really valuable, it'd probably be better as > an inline function, or as it's only used once, just > as direct code in that one place. Fine, I get it. Thanks for the advice.:-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >