From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938084AbdAEHyu (ORCPT ); Thu, 5 Jan 2017 02:54:50 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:43540 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523AbdAEHxb (ORCPT ); Thu, 5 Jan 2017 02:53:31 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a3d-f79a36d000004dcf-1f-586dfb58ff92 Content-transfer-encoding: 8BIT Message-id: <586DFB53.9050709@samsung.com> Date: Thu, 05 Jan 2017 16:52:51 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , Rob Herring , Hoegeun Kwon Cc: thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang Subject: Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board In-reply-to: <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIJsWRmVeSWpSXmKPExsWy7bCmrm7k79wIgxkBFrfWnWO16D13ksni +pfnrBbzjwC518/bWVz5+p7N4v3yLjaLpTP6WC1u/Gpjteh//JrZ4vz5DewWl3fNYbOYcX4f k8X/PTvYLX7umsfiwO+xc9Zddo9NqzrZPLZ/e8Dqcb/7OJNH35ZVjB6fN8kFsEWl2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAXaykUJaYUwoUCkgs LlbSt7Mpyi8tSVXIyC8usVWKNjQ00jM0MNczMjLSMzGOtTIyBSpJSM3YP3MpW8EjnYpTPx6w NzCelO1i5OSQEDCRuLNzKQuELSZx4d56ti5GLg4hgR2MEk2rVjNDOO1MEhcWPmGG6bj37Bwj RGI5o8T5TYtZQRK8AoISPybfAxrFwcEsIC9x5FI2SJhZQFNi6+717BD19xglft7awgxSwyug JfHiVBWIySKgKnFwKyNIORuQOXHFfTYQW1QgQmLn/G/sICUiAoUSh6bEgExhFrjGJLHhwymw emGBKIkXsyeBPcApYC9x7lMH2GkSAm/ZJdoObGcEaZYQkJXYdADqfBeJ5T+OMUHYwhKvjm9h h7ClJVb9u8UE0dvNKHG9p4cNwulglPjb+R8aRMYS9x/cY4Z4jE/i3dceVogFvBIdbUIQJR4S PfM+QpU7Sny5cAkaVoeYJG4/3c0+gVF+FlJwzUIE1yyk4FrAyLyKUSy1oDg3PbXYsMBSrzgx t7g0L10vOT93EyM4uWrZ7mD8cs7nEKMAB6MSD++NHzkRQqyJZcWVuYcYJTiYlUR4WX/lRgjx piRWVqUW5ccXleakFh9iNAUG90RmKdHkfGDizyuJNzQxMzQxMjE0NDcyMFIS513WaB0hJJCe WJKanZpakFoE08fEwSnVwFhRPXXCx4UBJm+nBOyP/lVbVXrwu3VjXcit2XdSTn/3Kbsd92xR 8d0De9b8eOG0/GemdIu5elP5DA3T7HNN8yfNbygXnLfGXFOqUEz6TXLcWaYplye1sW2RXGB1 TEePY2qduXIJ/6fl78N3FHya3c7xcWbkc6ZlvLOd1ttZneidq96eLWxYf1mJpTgj0VCLuag4 EQC348vDxAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t9jAd2I37kRBv869SxurTvHatF77iST xfUvz1kt5h8Bcq+ft7O48vU9m8X75V1sFktn9LFa3PjVxmrR//g1s8X58xvYLS7vmsNmMeP8 PiaL/3t2sFv83DWPxYHfY+esu+wem1Z1snls//aA1eN+93Emj74tqxg9Pm+SC2CLcrPJSE1M SS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvG /plL2Qoe6VSc+vGAvYHxpGwXIyeHhICJxL1n5xghbDGJC/fWs3UxcnEICSxllDh4+hEzSIJX QFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BRYsfxw+wgNbwCWhIvTlWBmCwCqhIH t4KNZwMyJ664zwYSFhWIkOg+UQkSFhEolPi14h/YFGaBa0wST86+YAKpERaIkmhdwgQx/RCT xOr5q1hAGjgF7CXOfepgnMAoMAvJcbMQjpuF5LgFjMyrGCVSC5ILipPScw3zUsv1ihNzi0vz 0vWS83M3MYKj9pnUDsaDu9wPMQpwMCrx8HoI5EYIsSaWFVfmHmKU4GBWEuFl/QUU4k1JrKxK LcqPLyrNSS0+xGgK9N5EZinR5HxgQskriTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEkNTs1 tSC1CKaPiYNTqoExY1HU2t2C1y/LOXFYbFGYyGlpEacQEmznsfqcphpXc2GA9dsq7u1HhGbn Fa3+bn5yx8WH2+Jj3nKqyTVtyJ7tsD4qYkmJapx18LXm1gc+gg8nnLasu/HoxcPnc42/zoiW U37QurgvUsL69qyp64o+z9p2fYJX9vZ/mhc3BE1MrzQLOXd88dvLSizFGYmGWsxFxYkAGoCs N/ACAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105075256epcas1p336e3f542101d6fdaa7a1d8f5639b109c X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170104081522epcas5p112698b2499e56dc9027ec1f57f8964ee X-RootMTR: 20170104081522epcas5p112698b2499e56dc9027ec1f57f8964ee References: <1483517711-23849-1-git-send-email-hoegeun.kwon@samsung.com> <1483517711-23849-3-git-send-email-hoegeun.kwon@samsung.com> <20170104144439.bzjab3ovixyt3i5b@rob-hp-laptop> <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 01월 05일 15:55에 Andrzej Hajda 이(가) 쓴 글: > On 04.01.2017 15:44, Rob Herring wrote: >> On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >>> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >>> driver. This panel has 1440x2560 resolution in 5.7-inch physical >>> panel in the TM2 device. >>> >>> Signed-off-by: Donghwa Lee >>> Signed-off-by: Hyungwon Hwang >>> Signed-off-by: Hoegeun Kwon >>> --- >>> .../bindings/display/panel/samsung,s6e3ha2.txt | 40 ++ >>> drivers/gpu/drm/panel/Kconfig | 6 + >>> drivers/gpu/drm/panel/Makefile | 1 + >>> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 741 +++++++++++++++++++++ >>> 4 files changed, 788 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> new file mode 100644 >>> index 0000000..6879f51 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> @@ -0,0 +1,40 @@ >>> +Samsung S6E3HA2 5.7" 1440x2560 AMOLED panel >>> + >>> +Required properties: >>> + - compatible: "samsung,s6e3ha2" >>> + - reg: the virtual channel number of a DSI peripheral >>> + - vdd3-supply: I/O voltage supply >>> + - vci-supply: voltage supply for analog circuits >>> + - reset-gpios: a GPIO spec for the reset pin (active low) >>> + - enable-gpios: a GPIO spec for the panel enable pin (active high) >>> + - te-gpios: a GPIO spec for the tearing effect synchronization signal >>> + gpio pin (active high) >>> + >>> +The device node can contain one 'port' child node with one child >>> +'endpoint' node, according to the bindings defined in [1]. This >>> +node should describe panel's video bus. >>> + >>> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt >>> + >>> +Example: >>> + >>> +&dsi { >>> + ... >>> + >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>> + >>> + port { >>> + panel_in: endpoint { >>> + remote-endpoint = <&dsi_out>; >> As I said previously, it makes no sense to have a graph to dsi_out it is >> simply the parent node. > > The problem is that exynos_dsi requires presence of endpoint node, when > it was written the policy was that graphs must be always present. > DSI reads from this node samsung,burst-clock-frequency and > samsung,esc-clock-frequency. For example in exynos4412-trats2.dts: > >> dsi_0: dsi@11C80000 { >> ... >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> >> port@1 { >> reg = <1>; >> >> dsi_out: endpoint { >> remote-endpoint = <&dsi_in>; >> samsung,burst-clock-frequency >> = <500000000>; >> samsung,esc-clock-frequency = >> <20000000>; >> }; >> }; >> }; >> >> panel@0 { >> ... >> port { >> dsi_in: endpoint { >> remote-endpoint = <&dsi_out>; >> }; >> }; >> }; >> }; > > However, DSI driver does not use remote-endpoint property, it is here > only to fulfill of_graph policy. > So if something like below is acceptable, we can get rid of port node in > panel: > >> dsi_0: dsi@11C80000 { >> ... >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> >> port@1 { >> reg = <1>; >> >> dsi_out: endpoint { >> samsung,burst-clock-frequency >> = <500000000>; >> samsung,esc-clock-frequency = >> <20000000>; >> }; >> }; >> }; >> >> panel@0 { >> ... >> }; >> }; > > What do you think? > > Other solution is to move problematic properties somewhere else, but > this require change of bindings. > Anyway I would be glad to remove port nodes in other samsung panels: > s6e8aa0, ld9040. In addition, Now dsi and mic device nodes of exynos5433.dtsi include remote nodes which define Display pipeline. This is wrong. Display pipeline is specific to board, not SoC so these things should be moved to exynos5433-tm2.dts file. Hoegeun, you can do this with other patch also. Thanks. > > Regards > Andrzej > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >