From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BF91A239A for ; Wed, 26 Nov 2025 03:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128312; cv=none; b=rIvaBTRUiZXdc8q+ZQdg47canSJNU7jgsTClOR5NWTDBZq7CwLXBHzUUxwLGv3w9uJzzDosvyBW0DLBE9g8JYa/LAttlSgzYcG9XGxyUOSj5LH1Z3YrJ9zi44o5ZiY7HL4nMPxtvYBBCVAwcByISIwMus6smzrvseLMyS/Ee5hY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128312; c=relaxed/simple; bh=UHLKn3LNAlGu9IKhXgxUcb2CmS+t3Ga3426hspRXFI0=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=q1uCHHbSiARmzucHuBZpAM8L1XZ71BLNbxUJpwAaMCd0aZozzYN9Dwr0dx9vEt3yfMq/lehte/hqPgCm+SUER3Oc+pn48ZJXhdKKh9M3/H9PzGha9GOICENqLm8fVFgmo8tHHTJfMlps5DZQn6WXeyHvapr3f6JplzZJHrC/OYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N7KY8YDw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FuliftW0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N7KY8YDw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FuliftW0" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5API1KKq2651045 for ; Wed, 26 Nov 2025 03:38:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= agDGgzRr5TSP9r6ApCG+csfzr79eR2JTLEqjVq7+3mA=; b=N7KY8YDwtjzD/UFH IJROtuCni8d/hH3xIr/oAq2EbKamSvJrT/78Bu23z5mr6Nteg+4qRHepivPTIWbO LQyjIL8XPG+Fpvs7eN4rPfnqzbextZm/Aj5tVNP5keF68wxF+tu7gxoL5tvArjN2 8+fIatH+I8374KbRcreucqqPleINny0ehcT42VgWI5mwAhR7K03EDHwjkBvD2lob tr8S8yetzqJxweUPyxvpeFWrC3UBtjGyBpmlJv3oAPwWyAEZ3R2oOZXlcgoca5Pb iZaYo+5dF1W3AM35yc9gyNvgx12LGRLYEe1YqzOX8WEp9ycyVCtEWF1t1ybX4IS7 Ey9kSw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anaabtnsf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 03:38:29 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b9ef46df43so6083313b3a.1 for ; Tue, 25 Nov 2025 19:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764128309; x=1764733109; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=agDGgzRr5TSP9r6ApCG+csfzr79eR2JTLEqjVq7+3mA=; b=FuliftW08WoCzRbQq6RQ5ZSSD3u68Akfg9Jd+zeisNqxPDLPU0tUAj+JoGi8R1oN5k +sSELtpbQQGUFtFrrj4NFMyMaFoEXztajHanHIwEL8gyQOi3FWIa7UOwrIYl7j9sOQYA c5iHGDji4tFVoz1LpNag3e4uTWd3kgpW0LXGa7HsJWrHuF+z6VoWzyHiYHMrifqsHqko DHGJgEw+hAGneUbBIrf2/ZkglGfwAP09IVKxhWQvwcHi6WuLUlcBo6QSr1box5iVDqE0 UDNmaCWkiczC1hhmyRlRSvu0QD3h7Yn9+q7zClJ+pmlFfqjRutHWTKICX6ublxcIulsI kqfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764128309; x=1764733109; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agDGgzRr5TSP9r6ApCG+csfzr79eR2JTLEqjVq7+3mA=; b=BE6Ri2Vev6IetDBPn2zcI8DhwZtY30PF3KzomA1UK6HZ/kxjUrB6NkA58FXt/1TaXP w1uIkz48eImiG7aqIljTdGit7g+Sfl5d45j178hwJuhJLG6geZXuJ1WJGhVaL8sP5HlG O9h2Z+YewhD6Xj3ynoh9yy1MoqfHA6OXh3b6b5vbfLoJ6/cxR+C/qkI4cwan1ONBYdlq Mbb21lN1WhiWsbfaoPAaNq2IRSiaGBmFlhuCxL72NvYc72s+/4dehCo+uk8tUG71Bf3e +IC/4AzDrVNvlSGkRVW4rNrFwcpQiHZOzWr4P/4L5yIZ6hpBtwJIHPd+qTzAcW9fuoGI psNw== X-Forwarded-Encrypted: i=1; AJvYcCWGAj5KiHd58YjpcMbbMED2i00Xwkf+Vxybwijan7+3vES5QUn3Jgyhgfu0owGfOkCNYKfESAlg1anXlJo=@vger.kernel.org X-Gm-Message-State: AOJu0YzuY1R5OBG0tagK0IaeT2MaUuyuF8AO6solW4kHsGZyHkLI77Np GQ+zYfK4eabmqpB6KRVKCZtfdgFV3eraFDA3gZAs5hf0AXLINoNiYxMtObe+v+53jsG2JLzqKw7 A88dbkWBByVydcA1KSKmOfYS1ytZd8tVo/pX5L5PBUZGLH0ugAk5k/DKAzwXa2nO4aFc= X-Gm-Gg: ASbGnctyqsYBY95gnoC5BFXDULurRpqpTgEPjta/KPy2Cz/tCz97rRq7qX1uZiKx3VS X/CuhRiembi3z/cYQa3bOaaY1JF3LZI1qz2PZDSJtjqorHiV+GOVJclqoMDKYUjKMBTI6WAQIiG dz0TMjDbLCd/oiJuYXjfaPZDle6rKu4qJmfkAJY3wKSZnZOP3SJYLYtQVEBBnhSGsOpy0AEX7Iv vV0rFYDI3QT4vZjo3i7Rk6lnb0chh+WhezPO6p5KF6SVV8t9sdjX1W4xhpr9EYTW2mDMxDocZM4 Nrjtsg7kqMtog+jzpzQgflXl8wc+SrX3vVQ38aTu+zZEVvzEo6QMf/T+9P4OhEgCH/GPen+QzoM dtseV4dGRd01TBHuFBXFGhK756e8pyb0ZIFTTIa5yPmms0o8PAiSOiUgLW/+9Ioti8dc4QQ== X-Received: by 2002:a05:6a00:a1e:b0:7ba:153f:5a40 with SMTP id d2e1a72fcca58-7ca879e956cmr5403800b3a.9.1764128309089; Tue, 25 Nov 2025 19:38:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTiG66hdYeGYiaCl9f/OqCieCXEYUJQxdu0p5mNi7NxXuiHye2hU5fq6jbx44J0e52G9P8Vw== X-Received: by 2002:a05:6a00:a1e:b0:7ba:153f:5a40 with SMTP id d2e1a72fcca58-7ca879e956cmr5403774b3a.9.1764128308544; Tue, 25 Nov 2025 19:38:28 -0800 (PST) Received: from [10.133.33.250] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0243b3csm19469225b3a.36.2025.11.25.19.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 19:38:28 -0800 (PST) Message-ID: <586c0ab5-ead1-4387-9f7a-d1943dffc7df@oss.qualcomm.com> Date: Wed, 26 Nov 2025 11:38:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] drm/msm/dp: fix the intf_type of MST interfaces From: Yongxing Mou To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20251125-mdss_catalog-v4-1-df651fba2702@oss.qualcomm.com> <3cnujrkkcui34wg3jrfoezradc5itm2paw5mgkii2d2snlac2a@lerj4ldbvf4l> <9515e743-b8bd-426c-9827-7d5a170445e0@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <9515e743-b8bd-426c-9827-7d5a170445e0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Vd36/Vp9 c=1 sm=1 tr=0 ts=69267635 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=GrdrOO9Tebfov7ezxyYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: Fz2GPi0lX2wk6vugMpTWzbsnLseQx6l_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDAyNiBTYWx0ZWRfX7p9WkPKggnY3 j/Do2ZZj6Yog4n+Vam5+iZySvur4qqgdUaDrbqD5aIb2dKL0UdmBEKu1JqzDRuzxNB6fVuTt7mT gRSku8Rg5KY3V73qFpnP4AlZCj8zFcI3lrqUEJiphYmVf+QJGMoTrlG/Ffz7UWW56CTxbUgsAyC theXydob+pjpL52VYJgN4ImzppgvSY46sbW3rSIqHKAXw9qoV7sFWM9+5OsZfIZloUwNUpoaNRI VzSoxzZilf3POkZu7I1p4ynae0uUAz7kwBKWTUFCELx+h41OLNljETeBjLMzZaqs0IaKzmVDVxr kj/M8ZYXSNo1N8atwXjBTItlmcUSB0QBesmbbIBARQs5u/4R3WwuRaMZcOhN+MSTbpX5SfVDVRE 8dv38RfTzbDG8n0ljEgMN8SVaM1lDA== X-Proofpoint-GUID: Fz2GPi0lX2wk6vugMpTWzbsnLseQx6l_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260026 On 11/26/2025 10:50 AM, Yongxing Mou wrote: > > > On 11/26/2025 8:36 AM, Dmitry Baryshkov wrote: >> On Tue, Nov 25, 2025 at 04:22:12PM +0800, Yongxing Mou wrote: >>> From: Abhinav Kumar >>> >>> Interface type of MST interfaces is currently INTF_NONE. Update this to >>> INTF_DP. And correct the intf_6 intr_underrun/intr_vsync index for >>> dpu_8_4_sa8775p. >>> >>> Signed-off-by: Abhinav Kumar >>> Signed-off-by: Yongxing Mou >>> Reviewed-by: Dmitry Baryshkov >>> --- >>> This patch was split out from the MST V3 patch series: >>> https://lore.kernel.org/all/20250825-msm-dp-mst- >>> v3-0-01faacfcdedd@oss.qualcomm.com/ >>> --- >>> Changes in v4: >>> - Splite chagne out from the MST V3 series. >> >> Why? >> > i just want to spelieete Sorry, please ignore this message and move to the other reply.>> - Link to v3: https://lore.kernel.org/ > all/20250825-msm-dp-mst-v3-37-01faacfcdedd@oss.qualcomm.com/ >>> >>> Changes in v3: >>> - Fix through the whole catalog >>> - Link to v2: https://lore.kernel.org/all/20250609-msm-dp-mst-v2-37- >>> a54d8902a23d@quicinc.com/ >>> >>> Changes in v2: >>> - Change the patch order in the series. >>> - Link to v1: https://lore.kernel.org/all/20241205-dp_mst-v1-3- >>> f8618d42a99a@quicinc.com/ >>> --- >>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h |  6 +++--- >>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h  | 12 +++++ >>> +------ >>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h |  6 +++--- >>>   3 files changed, 12 insertions(+), 12 deletions(-) >>> >>> @@ -363,15 +363,15 @@ static const struct dpu_intf_cfg sa8775p_intf[] >>> = { >>>       }, { >>>           .name = "intf_6", .id = INTF_6, >>>           .base = 0x3A000, .len = 0x280, >>> -        .type = INTF_NONE, >>> +        .type = INTF_DP, >>>           .controller_id = MSM_DP_CONTROLLER_0,    /* pair with >>> intf_0 for DP MST */ >>>           .prog_fetch_lines_worst_case = 24, >>> -        .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17), >>> -        .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16), >>> +        .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16), >>> +        .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17), >> >> This is a separate fix, it should be a separate patch. >> >