From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753305AbdJ3VTH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Oct 2017 17:19:07 -0400
Received: from mail-lf0-f68.google.com ([209.85.215.68]:49522 "EHLO
        mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752571AbdJ3VTF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Oct 2017 17:19:05 -0400
X-Google-Smtp-Source: ABhQp+RJi6GxYs75R/6hD4ioK2yI9q+g0Fp7yPeV4bgaCVe3gi7Cpl0nJtwztWCGVYTCQlHEghVOIA==
Subject: Re: [PATCH] ravb: Use common error handling code in ravb_probe()
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eugeniu Rosca <erosca@de.adit-jv.com>,
        Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
        Masaru Nagai <masaru.nagai.vx@renesas.com>,
        =?UTF-8?Q?Niklas_S=c3=b6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Simon Horman <horms+renesas@verge.net.au>,
        Yuval Shaia <yuval.shaia@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <2839c3c2-0116-7549-6ff4-a49eb0a52298@users.sourceforge.net>
 <b45f9416-5b89-17e3-df0b-905dd01d5342@cogentembedded.com>
Organization: Cogent Embedded
Message-ID: <587725d6-2eeb-c95c-1cfe-0c6571a74c7c@cogentembedded.com>
Date: Tue, 31 Oct 2017 00:19:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <b45f9416-5b89-17e3-df0b-905dd01d5342@cogentembedded.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/30/2017 11:51 PM, Sergei Shtylyov wrote:

>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 28 Oct 2017 19:10:08 +0200
>>
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
> 
>     Have you actually tried to see if there's any change in the resulting 
> object code? I've looked at ARM gcc 4.8.5's output and it didn't really change 
> -- gcc was able to optimize these repetitive assignments pretty well...
> 
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>   drivers/net/ethernet/renesas/ravb_main.c | 32 
>> ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
>     Diffstat also speaks about the futility of this patch.

    Ah, you've added empty lines where there was none... Please don't do this.
I'll ACK the v2 patch, given my comments are addressed.

[...]

MBR, Sergei