From: Michael Straube <straube.linux@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove write-only variable bLCKInProgress
Date: Sat, 11 Sep 2021 15:32:35 +0200 [thread overview]
Message-ID: <58796c32-5105-b3a3-fdeb-bf38e97ecd6b@gmail.com> (raw)
In-Reply-To: <20210911132338.1415-1-martin@kaiser.cx>
On 9/11/21 15:23, Martin Kaiser wrote:
> bLCKInProgress in struct odm_rf_cal is never read. Remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 4 ----
> drivers/staging/r8188eu/include/odm.h | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> index 6e0abaf58791..d9693c8014ce 100644
> --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> @@ -1212,16 +1212,12 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt)
> timecount += 50;
> }
>
> - dm_odm->RFCalibrateInfo.bLCKInProgress = true;
> -
> if (dm_odm->RFType == ODM_2T2R) {
> phy_LCCalibrate_8188E(adapt, true);
> } else {
> /* For 88C 1T1R */
> phy_LCCalibrate_8188E(adapt, false);
> }
> -
> - dm_odm->RFCalibrateInfo.bLCKInProgress = false;
> }
>
> static void phy_setrfpathswitch_8188e(struct adapter *adapt, bool main, bool is2t)
> diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
> index 7c8f082930dd..cda8b3ffe0be 100644
> --- a/drivers/staging/r8188eu/include/odm.h
> +++ b/drivers/staging/r8188eu/include/odm.h
> @@ -679,7 +679,6 @@ struct odm_rf_cal {
> u32 Reg864;
>
> bool bIQKInitialized;
> - bool bLCKInProgress;
> bool bAntennaDetected;
> u32 ADDA_backup[IQK_ADDA_REG_NUM];
> u32 IQK_MAC_backup[IQK_MAC_REG_NUM];
>
Compiles and looks good to me, thanks.
Acked-by: Michael Straube <straube.linux@gmail.com>
prev parent reply other threads:[~2021-09-11 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 13:23 Martin Kaiser
2021-09-11 13:32 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58796c32-5105-b3a3-fdeb-bf38e97ecd6b@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®