mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: raoxu <raoxu@uniontech.com>
Cc: mkl@pengutronix.de, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net,
	horms@kernel.org, skhan@linuxfoundation.org,
	rdunlap@infradead.org, linux-can@vger.kernel.org,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH can-next v2] can: bcm: Document cyclic transmission failures
Date: Wed, 18 Nov 2026 11:28:29 +0100	[thread overview]
Message-ID: <5884daae-c820-4e2b-b5d1-7ac2dfb6013a@hartkopp.net> (raw)
In-Reply-To: <75785AF83A9D9B09+20261118091938.3365557-1-raoxu@uniontech.com>



On 18.11.26 10:19, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
> 
> The CAN broadcast manager continues its configured cyclic transmission
> schedule even when a CAN frame cannot be passed to the configured
> network interface.
> 
> Such failures are not reported to user space. The failed transmission
> is not retried by the broadcast manager, the timing remains unchanged,
> and a non-zero count is decremented.
> 
> As a result, a TX_EXPIRED notification requested with TX_COUNTEVT
> indicates that the configured transmissions at ival1 have been
> processed, not that they were successfully sent.
> 
> Document this behavior to prevent applications from treating TX_EXPIRED
> as confirmation of successful transmission.
> 
> Suggested-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Many thanks,
Oliver

> ---
> Changes in v2:
> - Target can-next as requested by Oliver Hartkopp.
> - Adopt Oliver's suggested wording describing transmission failures
>    from the user's perspective.
> - Clarify the TX_EXPIRED notification semantics and scope the lack of
>    retries to the broadcast manager.
> - Remove implementation details and redundant descriptions.
> 
> This documentation-only update follows the review of v1. The earlier
> proposal to change BCM transmission accounting was dropped.
> 
>   Documentation/networking/can.rst | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index 51bc70748f75..ae47f40bf456 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -892,6 +892,14 @@ only one timer is needed 'count' is set to zero and only 'ival2' is used.
>   When SET_TIMER and START_TIMER flag were set the timers are activated.
>   The timer values can be altered at runtime when only SET_TIMER is set.
> 
> +If a CAN frame cannot be passed to the configured CAN network interface
> +(e.g. due to a full transmit queue or the interface being down), this
> +failure is not reported to user space. The transmission sequence
> +continues as configured: the frame is not retried by the broadcast
> +manager, the timing remains unchanged, and a non-zero ``count`` is
> +decremented anyway. Therefore, a ``TX_EXPIRED`` notification (requested
> +with ``TX_COUNTEVT``) only indicates that the ``count`` transmissions
> +at ``ival1`` have been processed, not that they were successfully sent.
> 
>   Broadcast Manager message sequence transmission
>   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --
> 2.50.1
> 


      reply	other threads:[~2026-11-18 10:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:19 raoxu
2026-11-18 10:28 ` Oliver Hartkopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5884daae-c820-4e2b-b5d1-7ac2dfb6013a@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raoxu@uniontech.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®