From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761955AbcINLsJ (ORCPT ); Wed, 14 Sep 2016 07:48:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:49196 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761931AbcINLsI (ORCPT ); Wed, 14 Sep 2016 07:48:08 -0400 Subject: Re: [PATCH 03/15] hisi_sas: keep CHL_INT2 masked for v2 HW To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> <1473176185-217808-4-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <5885219f-71c7-418d-f502-57022aaa1587@suse.de> Date: Wed, 14 Sep 2016 13:48:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1473176185-217808-4-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 05:36 PM, John Garry wrote: > None of the CHL_INT2 interrupts are serviced > in the channel irq ISR, so leave the interrupt > source masked. > The interrupt mask is initially set in > init_reg_v2_hw(). > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > index e0c124b..25e7c58 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > @@ -965,14 +965,8 @@ static void start_phys_v2_hw(unsigned long data) > > static void phys_init_v2_hw(struct hisi_hba *hisi_hba) > { > - int i; > struct timer_list *timer = &hisi_hba->timer; > > - for (i = 0; i < hisi_hba->n_phy; i++) { > - hisi_sas_phy_write32(hisi_hba, i, CHL_INT2_MSK, 0x6a); > - hisi_sas_phy_read32(hisi_hba, i, CHL_INT2_MSK); > - } > - > setup_timer(timer, start_phys_v2_hw, (unsigned long)hisi_hba); > mod_timer(timer, jiffies + HZ); > } > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)