From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750751AbdAWDfI (ORCPT ); Sun, 22 Jan 2017 22:35:08 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:56356 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdAWDfH (ORCPT ); Sun, 22 Jan 2017 22:35:07 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a39-f79c86d000001a4c-9d-588577902d4f Content-transfer-encoding: 8BIT Message-id: <5885778F.7010004@samsung.com> Date: Mon, 23 Jan 2017 12:25:03 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, "linux-pm@vger.kernel.org" Cc: Kyungmin Park , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] PM / devfreq: Modify the device name as devfreq[X] for sysfs In-reply-to: <20170123021924epcms1p86578a78189221928e48ede3e26ecce38@epcms1p8> X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTcRTmt7vdXavZz6l1MLV5QShjy7umzsooejB62Ciykahd9eKkPeTe +QoijcoYKpoUpKGChbqKwMxHEeajgkpNQ+i5Ck3sgUhWaPTa9Sr133fO+b7f+X0fhyLUvxUh VLbDxfEO1kaTi+Rtvau12or8U5bo8s4IY/+Jz0rj01sXSeN0WR8yvixuIo2PHw0rNitMrSMl clN5qweZplvCzcQhbqOVYzM5XsM5MpyZ2Y6sBHrX/rStaTGx0YyWiTfG0RoHa+cS6G27zdod 2TbfSlqTx9pyfS0zKwj02k0beWeui9NYnYIrgU5mGL2OiY7T6fV6nWFdynp9jI9ymLP2dleQ OQ/IgqLyh0QRalC4kR8F2ADv6rsICS+DJ97rpBstotS4A0FZ/U1CKkpkcPXuqHxB8fjWmEIa NCL4MzOlFAcqHAAzVV4fiaIIvBL6ho+IbQKvhomvZ+US34uga3xCJnJUOAq6e0NFKMeR8LMO i3TS1+2aeEaKeCmOgJGZUSTiYGyBzrrvSpEehA9A1xW1+CKBLyD4UvVq7geB+BBU3hmaM+OH E6Gm3T1nBnCtEpovewlRDDgMWu7OG94GntuvSQkHwscHrUoJrwDP7xcySVuFwH3tFyEVpQiK r96bV6yDN2+9hGTSHya/lSqkBSo4c1otUUxwqe78/KNb4Gmzdz7Q174cbtTKKpCm+r/oqv9F V/1fdPWI8KBlXI5gz+IEJidGJ7B2IdeRpctw2lvQ3O1FxXeg+wO7exCmEL1Ehd+ftKgVbJ5Q aO9BQBF0kOqg85RFrcpkC49yvDONz7VxQg+K8UVfSYQEZzh9l+xwpTGGWMagNzBMnD5aTy9X NRRvsKhxFuvijnBcDscv6GSUX0gRSrSab/iHDQ/xszWB6UPs4u2x3s6lyjUHPadbQ/GSlKN/ 3oW6bfxA5PFfDdbwwwHppTWTtguDBVv9Bs1s5XjZLvNYnKwxIGNP0M5V+96kPr8/E+sqmJht aHP0p+8dabrmKQn1T8Xu8OHCYx/OJeX/mIoyPUtut32K6C1UJDUK3UG0XLCyTBTBC+xffJ30 I5EDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t9jAd0J5a0RBhP6eCzONr1ht7i8aw6b xefeI4wWtxtXsFmcOX2J1YHVY8vVdhaPvi2rGD0+b5ILYI5ys8lITUxJLVJIzUvOT8nMS7dV Cg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bhgxPYCo6zVTT0nWJu YFzM2sXIySEhYCJxZtcTKFtM4sK99WxdjFwcQgJLGSV+XT3JDpLgFRCU+DH5HksXIwcHs4C8 xJFL2RCmusSUKbkQ5Q8YJVourWcHifMKaEkcPCwDYrIIqEr8mS8AMoQNKLr/xQ02EJtfQFHi 6o/HjCAlogIREt0nKkHCIgKhEremTWYGmcgsMJNR4vXTY2CXCQtESUx9uJEZYtVdRonD//rA LuMU8JOYvb2LbQKj4Cwkh85COHQWwqELGJlXMUqkFiQXFCel5xrmpZbrFSfmFpfmpesl5+du YgTH0jOpHYwHd7kfYhTgYFTi4RV42hIhxJpYVlyZe4hRgoNZSYQ3PL81Qog3JbGyKrUoP76o NCe1+BCjKdCrE5mlRJPzgXGeVxJvaGJuYm5sYGFuaWlipCTO2zj7WbiQQHpiSWp2ampBahFM HxMHp1QDY+zXxnXLf7cra1068mHDkxzPpzXhC/a5Hn64yihmx3yFeX8NP19/nHsh6aigm2W2 uPDzi4G3ZvXptvtsN3z4cN907ubzYqlLnmyYEnr9zfzoU/a/r4hcb+j/a+ZxpPV30seP717W qFZt2d39aN5FTcWCJVmGR/2P7Li/0drT91DrpSW3Jq6YpxisxFKckWioxVxUnAgAChrPbLsC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170123032504epcas1p4ca4ba0b0281c0f6e20f9eacc157f4ed6 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170116122609epcas5p3e9f106e6d097613cd866107bc0e065c7 X-RootMTR: 20170116122609epcas5p3e9f106e6d097613cd866107bc0e065c7 References: <1484569567-29810-1-git-send-email-cw00.choi@samsung.com> <20170123021924epcms1p86578a78189221928e48ede3e26ecce38@epcms1p8> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 01월 23일 11:19, MyungJoo Ham wrote: >> if (!dev || !profile || !governor_name) { >> @@ -568,7 +569,8 @@ struct devfreq *devfreq_add_device(struct device *dev, >> mutex_lock(&devfreq->lock); >> } >> >> - dev_set_name(&devfreq->dev, "%s", dev_name(dev)); >> + dev_set_name(&devfreq->dev, "devfreq%lu", >> + (unsigned long)atomic_inc_return(&devfreq_no)); > > Do you have any specific reason to use "unsigned long" here? > (atomic_t has 32bit int). There is no any reason. I'll change to use the integer value as following: dev_set_name(&devfreq->dev, "devfreq%d", atomic_inc_return(&devfreq_no)); > >> err = device_register(&devfreq->dev); >> if (err) { >> mutex_unlock(&devfreq->lock); >> -- >> 1.9.1 -- Best Regards, Chanwoo Choi S/W R&D Center Samsung Electronics