From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>
Cc: "oe-kbuild@lists.linux.dev" <oe-kbuild@lists.linux.dev>,
"lkp@intel.com" <lkp@intel.com>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>,
"Gian Carlo Boffa (gcboffa)" <gcboffa@cisco.com>,
"Arulprabhu Ponnusamy (arulponn)" <arulponn@cisco.com>,
"Arun Easi (aeasi)" <aeasi@cisco.com>
Subject: Re: drivers/scsi/fnic/fdls_disc.c:263 fdls_schedule_oxid_free_retry_work() warn: inconsistent indenting
Date: Thu, 20 Feb 2025 08:50:07 +0300 [thread overview]
Message-ID: <5886f4ff-d6be-4804-8c76-c431946128a5@stanley.mountain> (raw)
In-Reply-To: <SJ0PR11MB5896888C81BFF2EB81E2B533C3C42@SJ0PR11MB5896.namprd11.prod.outlook.com>
On Thu, Feb 20, 2025 at 03:10:26AM +0000, Karan Tilak Kumar (kartilak) wrote:
> On Saturday, February 15, 2025 1:03 PM, Karan Tilak Kumar (kartilak) wrote:
> >
> > On Friday, February 14, 2025 7:03 AM, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> > >
> > > On Fri, Feb 14, 2025 at 05:42:25PM +0300, Dan Carpenter wrote:
> > > >
> > > > I guess we can't call schedule_delayed_work() without holding the
> > > > spin_lock? It's a strange thing.
> > >
> > > Actually, I see now that we're just dropping the lock to avoid a sleeping
> > > in atomic warning with the GFP_ATOMIC allocation... I bet you could make
> > > the code under the lock much smaller. Just the test_and_clear_bit() stuff
> > > basically.
> > >
> > > regards,
> > > dan carpenter
>
> The window can be further reduced by adding the lock/unlock around the list_add_tail. But this looks good too.
>
Could you send the patch for this. I don't know the code that well and
can't test it.
regards,
dan carpenter
next prev parent reply other threads:[~2025-02-20 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 14:42 Dan Carpenter
2025-02-14 15:02 ` Dan Carpenter
2025-02-15 21:03 ` Karan Tilak Kumar (kartilak)
2025-02-20 3:10 ` Karan Tilak Kumar (kartilak)
2025-02-20 5:50 ` Dan Carpenter [this message]
2025-02-20 22:13 ` Karan Tilak Kumar (kartilak)
2025-02-20 3:08 ` Karan Tilak Kumar (kartilak)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5886f4ff-d6be-4804-8c76-c431946128a5@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aeasi@cisco.com \
--cc=arulponn@cisco.com \
--cc=gcboffa@cisco.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®