From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdAYAf4 (ORCPT ); Tue, 24 Jan 2017 19:35:56 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:34864 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdAYAfy (ORCPT ); Tue, 24 Jan 2017 19:35:54 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2e-f79656d0000012f2-66-5887f2e70507 Content-transfer-encoding: 8BIT Message-id: <5887F2E6.7060205@samsung.com> Date: Wed, 25 Jan 2017 09:35:50 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Martin Kaiser , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Krzysztof Kozlowski , Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: samsung: mark s3c...._clk_sleep_init() as __init In-reply-to: <1485293599-23581-1-git-send-email-martin@kaiser.cx> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNJsWRmVeSWpSXmKPExsWy7bCmpu7zT+0RBpN/ylj0P37NbHH+/AZ2 i02Pr7FafOy5x2pxedccNosZ5/cxWWx8F2lx+E07q8WPM90sFqt2/WF04PK43NfL5LFz1l12 j67rW1g8Nq3qZPPYvKTeo2/LKkaPz5vkAtijUm0yUhNTUosUUvOS81My89JtlbyD453jTc0M DHUNLS3MlRTyEnNTbZVcfAJ03TJzgK5TUihLzCkFCgUkFhcr6dvZFOWXlqQqZOQXl9gqRRsa GukZGpjrGRkZ6ZkYx1oZmQKVJKRmrPt1lrmgmb3i3+2HzA2Mz1i7GDk5JARMJA7unMYGYYtJ XLi3Hsjm4hASWMoo8ezWcxaQhJBAO5PEtVl+MA09R/ZDFc1hlDi4aRI7SIJXQFDix+R7QA0c HMwC8hJHLmWDhJkFNCW27l7PDlF/j1HiYf9SFoh6LYn/U/6AXcEioCqx68x9MJsNKL7/xQ2w i/gFFCWu/njMCGKLCkRI7Jz/DWyQiMBzRonFnzayQWxoY5S4tgWsSFjAS+Lnxn6wBZwCjhKL J35lBmmQELjFLtF37wkTyHUSArISmw4wQ3zjIvFlYTcjhC0s8er4FnYIW1ri79JbjBC93YwS a142sUI4PYwSjWuOQgPMWOL+g3vMEFfwSfT+hlnAK9HRJgRR4iFx4uk8qHJHiYvTTkODYgqj xMLp/ewTGBVmIYXeLETozUIKvQWMzKsYxVILinPTU4tNC4z1ihNzi0vz0vWS83M3MYITqpbe DsZ/C7wPMQpwMCrx8Bq8b48QYk0sK67MPcQowcGsJML76AJQiDclsbIqtSg/vqg0J7X4EKMp MPAnMkuJJucDk31eSbyhiZmhiZElEJobmiuJ8y6osI4QEkhPLEnNTk0tSC2C6WPi4JRqYPRs lb26zeu+aOPL80p/5xyo5dP8OjfsFXtvqMeNXtFtGTknLNcfXX1wWeGSnYu/LvbdZ8SjvPfP R5fzXOkLjPjMToq0hK5f+zHFaKp+Wc7TrTNkT0a8eLL5anqQU/fa1/Ub//+4/fbANFOBH+Yb vIuuZ2yc/qrj7sufKl6PHzrfub5WgPGvUuR1JZbijERDLeai4kQAaNbF374DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jQd3nn9ojDA7181n0P37NbHH+/AZ2 i02Pr7FafOy5x2pxedccNosZ5/cxWWx8F2lx+E07q8WPM90sFqt2/WF04PK43NfL5LFz1l12 j67rW1g8Nq3qZPPYvKTeo2/LKkaPz5vkAtij3GwyUhNTUosUUvOS81My89JtlUJD3HQtlBTy EnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X4Jax7tdZ5oJm9op/tx8yNzA+Y+1i5OSQ EDCR6Dmynw3CFpO4cG89kM3FISQwi1Fi5/mHzCAJXgFBiR+T77F0MXJwMAvISxy5lA0SZhZQ l5g0bxEzRP0DRomDU+5A1WtJ/J/yB2wBi4CqxK4z98FsNqD4/hc3wJbxCyhKXP3xmBFkpqhA hET3iUqQOSICzxklNj/aATaUWaCNUWL3mntMIA3CAl4SPzf2s4DYQgLTGCV6jwqA2JwCjhKL J35lnsAoOAvJrbMQbp2F5NYFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYIj9Zn0 DsbDu9wPMQpwMCrx8E5Iao8QYk0sK67MPcQowcGsJML76AJQiDclsbIqtSg/vqg0J7X4EKMp 0LMTmaVEk/OBSSSvJN7QxNzE3NjAwtzS0sRISZy3cfazcCGB9MSS1OzU1ILUIpg+Jg5OqQbG BRmOm7TXO/O1FU3Jzrcx9U/4rBv2a89vpluCy+Q+/hExPjlp9RnW7t0uy7oSw5p82J31bu4T PnDvxkPux2ds2ouy1E5N/DaJ+c88r1/b5z31S+zOivP3ipwXveNbAWNK9h0RUZd3plErZ9qV NOpEpS0xmj916l1+4b3HvZn0XO639t/e+n23EktxRqKhFnNRcSIAEGmQl+oCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170125003551epcas5p16391275c443c43d331260a607b657945 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170124213354epcas2p48cd7596378462562c66017fe39774bb0 X-RootMTR: 20170124213354epcas2p48cd7596378462562c66017fe39774bb0 References: <1485293599-23581-1-git-send-email-martin@kaiser.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On 2017년 01월 25일 06:33, Martin Kaiser wrote: > These functions are called only by other __init functions. > Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y, > I get warnings like > > WARNING: vmlinux.o(.text+0x198350): > Section mismatch in reference from the function s3c2410_clk_sleep_init() > to the (unknown reference) .init.data:(unknown) > > Marking the s3c...._clk_sleep() functions as __init fixes this. > > Signed-off-by: Martin Kaiser > --- > drivers/clk/samsung/clk-s3c2410.c | 4 ++-- > drivers/clk/samsung/clk-s3c2412.c | 4 ++-- > drivers/clk/samsung/clk-s3c2443.c | 4 ++-- > drivers/clk/samsung/clk-s3c64xx.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) Looks good to me. Reviewed-by: Chanwoo Choi [snip] -- Best Regards, Chanwoo Choi Samsung Electronics