mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linusw@kernel.org, brgl@kernel.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	biju.das.jz@bp.renesas.com, claudiu.beznea@tuxon.dev,
	linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pinctrl: renesas: rzg2l: Use -ENOTSUPP instead of -EOPNOTSUPP
Date: Fri, 22 May 2026 12:17:05 +0300	[thread overview]
Message-ID: <588934dc-8a92-4952-8280-cc131d2cf035@kernel.org> (raw)
In-Reply-To: <CAMuHMdVK7Wu=Lv1Qhu0+CMCQSXv6Lj6BoTdzVoW1K5Z=kgecag@mail.gmail.com>

Hi, Geert,

On 5/22/26 12:11, Geert Uytterhoeven wrote:
> Hi Claudiu,
> 
> On Fri, 15 May 2026 at 14:40, Claudiu Beznea <claudiu.beznea@kernel.org> wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> The pinctrl and GPIO core code make exceptions for the -ENOTSUPP error
>> code. One such example is gpio_set_config_with_argument_optional(), which
>> returns success when gpio_set_config_with_argument() returns -ENOTSUPP, but
>> reports failure for all other error codes.
>>
>> Returning -EOPNOTSUPP from the pinctrl driver on the unsupported pinctrl
>> operation may lead to boot failures when pinctrl drivers implements
>> struct gpio_chip::set_config, the system uses GPIO hogs, and the
>> struct gpio_chip::set_config implementation returns -EOPNOTSUPP for the
>> unsupported operations.
>>
>> Return -ENOTSUPP for the unsupported pinctrl operation.
>>
>> Fixes: 560c633d378a ("pinctrl: renesas: rzg2l: Drop oen_read and oen_write callbacks")
>> Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-pinctrl for v7.2.
> 
> I guess drivers/pinctrl/renesas/pinctrl-rzv2m.c needs a similar patch?

Yes! I'll prepare and send one.

-- 
Thank you,
Claudiu


  reply	other threads:[~2026-05-22  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 12:40 [PATCH v2 0/2] pinctrl: renesas: rzg2l: Populate GPIO set_config Claudiu Beznea
2026-05-15 12:40 ` [PATCH v2 1/2] pinctrl: renesas: rzg2l: Use -ENOTSUPP instead of -EOPNOTSUPP Claudiu Beznea
2026-05-18  9:10   ` Bartosz Golaszewski
2026-05-22  9:11   ` Geert Uytterhoeven
2026-05-22  9:17     ` Claudiu Beznea [this message]
2026-05-15 12:40 ` [PATCH v2 2/2] pinctrl: renesas: rzg2l: Populate struct gpio_chip::set_config Claudiu Beznea
2026-05-18  9:10   ` Bartosz Golaszewski
2026-05-22  9:12   ` Geert Uytterhoeven
2026-05-22  9:12 ` [PATCH v2 0/2] pinctrl: renesas: rzg2l: Populate GPIO set_config Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=588934dc-8a92-4952-8280-cc131d2cf035@kernel.org \
    --to=claudiu.beznea@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=brgl@kernel.org \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=geert@linux-m68k.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome