From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Miles Chen <miles.chen@mediatek.com>, <lkp@intel.com>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
<angelogioacchino.delregno@collabora.com>,
<bjorn.andersson@linaro.org>, <kbuild-all@lists.01.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-remoteproc@vger.kernel.org>, <mathieu.poirier@linaro.org>,
<matthias.bgg@gmail.com>
Subject: Re: [PATCH v2] remoteproc: mediatek: fix side effect of mt8195 sram power on
Date: Mon, 14 Mar 2022 19:12:03 +0800 [thread overview]
Message-ID: <588cb791c2fe3e1db8e0dd9ad66aa6d1bb95b348.camel@mediatek.com> (raw)
In-Reply-To: <20220313000110.3869-1-miles.chen@mediatek.com>
Hi Miles,
On Sun, 2022-03-13 at 08:01 +0800, Miles Chen wrote:
> Hi Tinghan,
>
> > 418 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS
> > drivers/remoteproc/mtk_scp.c:418:27: note: each undeclared identifier is reported only once
> > for each function it appears in
> > drivers/remoteproc/mtk_scp.c: In function 'mt8195_scp_stop':
> > drivers/remoteproc/mtk_scp.c:592:28: error: 'MT8195_L1TCM_SRAM_PDN_RESERVED_BITS' undeclared
> > (first use in this function); did you mean 'MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS'?
> > 592 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS
>
> I tested this patch and it can should be caught by the
> internal build test.
>
> Could you do the test before submitting patches out?
>
>
> Thanks,
> Miles
I'm Sorry. I was too confident for this change.
I'll do the test at next time.
Thank you.
Best regards,
TingHan
next prev parent reply other threads:[~2022-03-14 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 12:30 Tinghan Shen
2022-03-11 13:05 ` AngeloGioacchino Del Regno
2022-03-14 11:15 ` Tinghan Shen
2022-03-11 16:57 ` kernel test robot
2022-03-13 0:01 ` Miles Chen
2022-03-14 11:12 ` Tinghan Shen [this message]
2022-03-11 23:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588cb791c2fe3e1db8e0dd9ad66aa6d1bb95b348.camel@mediatek.com \
--to=tinghan.shen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bjorn.andersson@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®