From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7CB6C1F4CB7 for ; Tue, 10 Jun 2025 17:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749576954; cv=none; b=MBgm2SoVVpxRPZuqfjcgQESPZbd+xwe77ZXIKcppgLpTsSjwUUt1aLY3uA5Pdvv/eo59bzj8NnyF8qgGIBLvN+k67wfIYenvqCvqHKdw1j31fqScYxLdEzOYO+fNcQK7+kaeiDRHa8kb9o1O8O8xnHeLZ2rCyBObj60xs0rFH98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749576954; c=relaxed/simple; bh=YWMs+H1R1avtUz7Zxo5I8qnCe4kbf3dkkem3H/EZHXQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=LBvpTJLZeS+sQOixM6MM0f//1RpreKkBDebvSypJ3FmtfDRrEHChOqGbOQ/8QD0B23LjYrxJi7el/NANoKpeHtEbSkZ1MspCTRaIw5h/9UHL7KAoECYJE8hP1K5GTl4QTB2NBPCgrej+9r0emFO1C48So1mVg8xJP4GkoqnEjG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=flmXs/dX; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="flmXs/dX" Received: from [100.65.129.218] (unknown [20.236.11.29]) by linux.microsoft.com (Postfix) with ESMTPSA id AEA0B2078629; Tue, 10 Jun 2025 10:35:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AEA0B2078629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1749576952; bh=umcZeKbZ0X54bScCEOCTXGAU3+QgdJ62r0B59TeumYk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=flmXs/dXHK/B+qHt9LU9IhLoj3HuHe0sBJ/1ZbNarOMnqmasmi4QVMbJMA501IsBe GAwrz/bY9lYDN9HWZbrW0IAehElO8J+hWCDKUk34bWlkErk6FnklvC7bdpMI7iz/Cc F2allUsgFGgTI1sMgi7uThujt4wfIMzd8Rrbr8/k= Message-ID: <588d5a4b-72cf-4d2c-8eee-c4240ae067b5@linux.microsoft.com> Date: Tue, 10 Jun 2025 10:35:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Julia Lawall , Nicolas Palix , Andrew Morton , cocci@inria.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: misc: secs_to_jiffies script: Create dummy report To: Ricardo Ribalda References: <20250129-secs_to_jiffles-v1-1-35a5e16b9f03@chromium.org> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/10/2025 6:09 AM, Ricardo Ribalda wrote: > Hi > > On Wed, 29 Jan 2025 at 18:38, Easwar Hariharan > wrote: >> >> On 1/29/2025 12:06 AM, Ricardo Ribalda wrote: >>> When running cocci in report mode, eg: >>> $make coccicheck M="$dir" MODE=report >>> >>> It returns this error: >>> virtual rule report not supported >>> coccicheck failed >>> make: *** [Makefile:251: __sub-make] Error 2 >>> >>> Create a dummy rule to avoid this error and run the other cocci scripts. >>> >>> Fixes: 551dbd1ec7ff ("coccinelle: misc: add secs_to_jiffies script") >>> Signed-off-by: Ricardo Ribalda >>> --- >>> scripts/coccinelle/misc/secs_to_jiffies.cocci | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> index 8bbb2884ea5d..2d85dca16418 100644 >>> --- a/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >>> @@ -10,6 +10,7 @@ >>> // >>> >>> virtual patch >>> +virtual report >>> >>> @depends on patch@ constant C; @@ >>> >>> @@ -20,3 +21,8 @@ virtual patch >>> >>> - msecs_to_jiffies(C * MSEC_PER_SEC) >>> + secs_to_jiffies(C) >>> + >>> +// Dummy rule for report mode that would otherwise be empty and make spatch >>> +// fail ("No rules apply.") >>> +@script:python depends on report@ >>> +@@ >>> >> >> Sorry about that, and thanks for the patch! >> >> FWIW, >> >> Reviewed-by: Easwar Hariharan > > I just checked on 6.16rc1 and it is still failing. > > Could we land this while Mark's series is under review? > > Thanks! > Can you provide a pointer to Mark's series? I actually just implemented a proper report and context mode which I'm glad to send out. Thanks, Easwar (he/him)