mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Frank Li <Frank.li@nxp.com>, ming.qian@oss.nxp.com
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
	mirela.rabulea@oss.nxp.com, 	shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
		festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com,
	linux-imx@nxp.com, 	imx@lists.linux.dev,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] media: imx-jpeg: Move mxc_jpeg_free_slot_data() ahead
Date: Fri, 11 Apr 2025 14:47:44 -0400	[thread overview]
Message-ID: <588eb09a61dea0c07e02c8b474972c6ca9b3b3e8.camel@ndufresne.ca> (raw)
In-Reply-To: <Z/kpBXvJe/n2YHg7@lizhi-Precision-Tower-5810>

Le vendredi 11 avril 2025 à 10:36 -0400, Frank Li a écrit :
> On Fri, Apr 11, 2025 at 03:43:40PM +0800, ming.qian@oss.nxp.com wrote:
> > From: Ming Qian <ming.qian@oss.nxp.com>
> > 
> > Move function mxc_jpeg_free_slot_data() above mxc_jpeg_alloc_slot_data()
> > allowing to call that function during allocation failures.
> > No functional changes are made.
> > 
> > Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> > ---
> >  .../media/platform/nxp/imx-jpeg/mxc-jpeg.c    | 46 +++++++++++--------
> >  1 file changed, 26 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > index 0e6ee997284b..b2f7e9ad1885 100644
> > --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > @@ -752,6 +752,32 @@ static int mxc_get_free_slot(struct mxc_jpeg_slot_data *slot_data)
> >  	return -1;
> >  }
> > 
> > +static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg)
> > +{
> > +	/* free descriptor for decoding/encoding phase */
> > +	dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
> > +			  jpeg->slot_data.desc,
> > +			  jpeg->slot_data.desc_handle);
> > +	jpeg->slot_data.desc = NULL;
> > +	jpeg->slot_data.desc_handle = 0;
> 
> You add above two lines, it is not simple move function. Move above two
> line change to next patch.

What about just making this its own commit, give you the chance to
write down that your making that function safe to be called multiple
times ?

Nicolas

> 
> Frank
> 
> > +
> > +	/* free descriptor for encoder configuration phase / decoder DHT */
> > +	dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
> > +			  jpeg->slot_data.cfg_desc,
> > +			  jpeg->slot_data.cfg_desc_handle);
> > +	jpeg->slot_data.cfg_desc_handle = 0;
> > +	jpeg->slot_data.cfg_desc = NULL;
> 
> The same here.
> 
> > +
> > +	/* free configuration stream */
> > +	dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM,
> > +			  jpeg->slot_data.cfg_stream_vaddr,
> > +			  jpeg->slot_data.cfg_stream_handle);
> > +	jpeg->slot_data.cfg_stream_vaddr = NULL;
> > +	jpeg->slot_data.cfg_stream_handle = 0;
> 
> The same here.
> 
> > +
> > +	jpeg->slot_data.used = false;
> > +}
> > +
> >  static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg)
> >  {
> >  	struct mxc_jpeg_desc *desc;
> > @@ -798,26 +824,6 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg)
> >  	return false;
> >  }
> > 
> > -static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg)
> > -{
> > -	/* free descriptor for decoding/encoding phase */
> > -	dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
> > -			  jpeg->slot_data.desc,
> > -			  jpeg->slot_data.desc_handle);
> > -
> > -	/* free descriptor for encoder configuration phase / decoder DHT */
> > -	dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
> > -			  jpeg->slot_data.cfg_desc,
> > -			  jpeg->slot_data.cfg_desc_handle);
> > -
> > -	/* free configuration stream */
> > -	dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM,
> > -			  jpeg->slot_data.cfg_stream_vaddr,
> > -			  jpeg->slot_data.cfg_stream_handle);
> > -
> > -	jpeg->slot_data.used = false;
> > -}
> > -
> >  static void mxc_jpeg_check_and_set_last_buffer(struct mxc_jpeg_ctx *ctx,
> >  					       struct vb2_v4l2_buffer *src_buf,
> >  					       struct vb2_v4l2_buffer *dst_buf)
> > --
> > 2.43.0-rc1
> > 

  reply	other threads:[~2025-04-11 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11  7:43 [PATCH v4 0/4] media: imx-jpeg: Fix some motion-jpeg decoding ming.qian
2025-04-11  7:43 ` [PATCH v4 1/4] media: imx-jpeg: Move mxc_jpeg_free_slot_data() ahead ming.qian
2025-04-11 14:36   ` Frank Li
2025-04-11 18:47     ` Nicolas Dufresne [this message]
2025-04-11  7:43 ` [PATCH v4 2/4] media: imx-jpeg: Cleanup after an allocation error ming.qian
2025-04-11  7:43 ` [PATCH v4 3/4] media: imx-jpeg: Change the pattern size to 128x64 ming.qian
2025-04-11  7:43 ` [PATCH v4 4/4] media: imx-jpeg: Check decoding is ongoing for motion-jpeg ming.qian
2025-04-11 14:38   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=588eb09a61dea0c07e02c8b474972c6ca9b3b3e8.camel@ndufresne.ca \
    --to=nicolas@ndufresne.ca \
    --cc=Frank.li@nxp.com \
    --cc=eagle.zhou@nxp.com \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@oss.nxp.com \
    --cc=mirela.rabulea@oss.nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xiahong.bao@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®