From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <kernel-team@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block_dev: don't update file access position for sync direct IO
Date: Tue, 13 Dec 2016 21:08:18 -0700 [thread overview]
Message-ID: <58920289-6947-c079-6d96-779408436aeb@fb.com> (raw)
In-Reply-To: <d78aaba0928aa012d13eb462bbfc33cdddd0621a.1481684697.git.shli@fb.com>
On 12/13/2016 08:07 PM, Shaohua Li wrote:
> For sync direct IO, generic_file_direct_write/generic_file_read_iter
> will update file access position. Don't duplicate the update in
> .direct_IO. This cause my raid array can't assemble.
That's not great... Thanks, added.
--
Jens Axboe
next prev parent reply other threads:[~2016-12-14 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 3:07 Shaohua Li
2016-12-14 4:08 ` Jens Axboe [this message]
2016-12-14 10:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58920289-6947-c079-6d96-779408436aeb@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®