mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Clark <robdclark@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	Archit Taneja <architt@codeaurora.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: msm: remove unused variable
Date: Mon, 25 Apr 2016 00:15:25 +0200	[thread overview]
Message-ID: <5896780.Bh4uZt5xXD@wuerfel> (raw)
In-Reply-To: <CAF6AEGsDdAVvpeuiLMG5HavXD-T2MSVUq3==9vMz7zvynqCZjw@mail.gmail.com>

On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > A recent cleanup removed the only user of the 'kms' variable in
> > msm_preclose(), causing a harmless compiler warning:
> >
> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable]
> >
> > This removes the variable as well.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
> 
> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
> to me yesterday (a needed fix of a fix.. ;-))

I just realized that this is now the only defconfig warning we get in v4.6 with
a recent compiler. Any chance we can still squeeze this in the current release?

	Arnd

  reply	other threads:[~2016-04-24 22:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-16 20:41 Arnd Bergmann
2016-04-16 20:49 ` Rob Clark
2016-04-24 22:15   ` Arnd Bergmann [this message]
2016-04-25 11:47     ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5896780.Bh4uZt5xXD@wuerfel \
    --to=arnd@arndb.de \
    --cc=airlied@linux.ie \
    --cc=architt@codeaurora.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®