From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbdBIOku convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2017 09:40:50 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:37326 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbdBIOkr (ORCPT ); Thu, 9 Feb 2017 09:40:47 -0500 Message-Id: <589C8D610200007800138429@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Thu, 09 Feb 2017 07:40:17 -0700 From: "Jan Beulich" To: "Paul Durrant" Cc: , "Boris Ostrovsky" , "Juergen Gross" , Subject: Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs References: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> In-Reply-To: <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 09.02.17 at 15:17, wrote: > The code goes so far as to set the default return code to -ENOSYS but > then overrides this to -EINVAL in the switch() statement's default > case. If you already change this, isn't -ENOTTY the traditional way of indicating unsupported ioctls? Jan