From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5083C433F5 for ; Wed, 27 Oct 2021 16:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B68860F6F for ; Wed, 27 Oct 2021 16:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239385AbhJ0Q21 (ORCPT ); Wed, 27 Oct 2021 12:28:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31316 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239163AbhJ0Q20 (ORCPT ); Wed, 27 Oct 2021 12:28:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635351960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/Y6Y4Q6GIPOPylGz9rQN8XoIPlqV9Q9ShHOXlxCR0A=; b=DB54l3j71ePXSH9VgMLP2RZ7hUNQyzAaDSssj38h+9Hl/X5X+jni04xr1m9OrII9qsyf+p WW9qvF2AFfmZu01Ih/Rc+Xp9jYyjdKxHwzYlyya5RCnfTrfLqHDV/uSur83Duih+XIh9bC RnlrUBwmRJVVNs5nuVWKJYKq3sefmUo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-wAeo5q_BOKC_5B5KGdqdKg-1; Wed, 27 Oct 2021 12:25:58 -0400 X-MC-Unique: wAeo5q_BOKC_5B5KGdqdKg-1 Received: by mail-wm1-f70.google.com with SMTP id o22-20020a1c7516000000b0030d6f9c7f5fso1486726wmc.1 for ; Wed, 27 Oct 2021 09:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z/Y6Y4Q6GIPOPylGz9rQN8XoIPlqV9Q9ShHOXlxCR0A=; b=fUsbHShaZz3J0KyWtjsbCBtaVx7YDKCBHTjXvn9v2DdR+H1fIgHmKI68SxrMTd68Bg aeRisEJBVWVyqc6bGfsiiUjet+0t+dhR6KePmxtorthZD7Cc2OjbglD9KX1Afn4huAv3 0loWjVoUkfLSaiEocgD4ZeuNuYBqXcnZl1FgcdZi4mq4geqXEANOkLeOkJ55ZdAO3IcY WK7DEwLEAnfBcwjCru1YqHyySrHAa9979xkmCLGyqPrDr5UeyvW1UiFCzIEMGcfV34zy rw9RSri6XncCc7B6a+VNKJB3gZrKi91KGNlNhePn9eV0sYPGUnTCCr2GYsCLA8nfUdwf v9Ww== X-Gm-Message-State: AOAM530XpeGo4NJo27DcPrODWPGplr0yEK9LPGl6C7ZpcnfWMhZu2ejE 0IUaPalYOWoAOpP61DcZfZYcsLbMjspLPvDwFmXpVIolJPnV9H/qBNxx4CAqJ0XAqAXC4pnjTOK IV5iY+GNCw5iB0f55Zp3POCZo X-Received: by 2002:a5d:47a3:: with SMTP id 3mr28992996wrb.336.1635351957425; Wed, 27 Oct 2021 09:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsZpShVS8z4jeZCnUbx0hIbA5QO9JtAw7d4XS7O11tFXTam31Tg6xceWM7upXkhz7c+hDgJg== X-Received: by 2002:a5d:47a3:: with SMTP id 3mr28992960wrb.336.1635351957172; Wed, 27 Oct 2021 09:25:57 -0700 (PDT) Received: from [192.168.100.42] ([82.142.14.190]) by smtp.gmail.com with ESMTPSA id n7sm334197wra.37.2021.10.27.09.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 09:25:56 -0700 (PDT) Message-ID: <589f86e0-af0e-c172-7ec6-72148ba7b3b0@redhat.com> Date: Wed, 27 Oct 2021 18:25:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [syzbot] KASAN: slab-out-of-bounds Read in copy_data Content-Language: en-US To: "Michael S. Tsirkin" , Dmitry Vyukov Cc: syzbot , davem@davemloft.net, herbert@gondor.apana.org.au, jiri@nvidia.com, kuba@kernel.org, leonro@nvidia.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, mpm@selenic.com, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000a4cd2105cf441e76@google.com> <20211027111300-mutt-send-email-mst@kernel.org> From: Laurent Vivier In-Reply-To: <20211027111300-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2021 17:28, Michael S. Tsirkin wrote: > On Wed, Oct 27, 2021 at 03:36:19PM +0200, Dmitry Vyukov wrote: >> On Wed, 27 Oct 2021 at 15:11, Laurent Vivier wrote: >>> >>> On 26/10/2021 18:39, syzbot wrote: >>>> Hello, >>>> >>>> syzbot found the following issue on: >>>> >>>> HEAD commit: 9ae1fbdeabd3 Add linux-next specific files for 20211025 >>>> git tree: linux-next >>>> console output: https://syzkaller.appspot.com/x/log.txt?x=1331363cb00000 >>>> kernel config: https://syzkaller.appspot.com/x/.config?x=aeb17e42bc109064 >>>> dashboard link: https://syzkaller.appspot.com/bug?extid=b86736b5935e0d25b446 >>>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=116ce954b00000 >>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=132fcf62b00000 >>>> >>>> The issue was bisected to: >>>> >>>> commit 22849b5ea5952d853547cc5e0651f34a246b2a4f >>>> Author: Leon Romanovsky >>>> Date: Thu Oct 21 14:16:14 2021 +0000 >>>> >>>> devlink: Remove not-executed trap policer notifications >>>> >>>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=137d8bfcb00000 >>>> final oops: https://syzkaller.appspot.com/x/report.txt?x=10fd8bfcb00000 >>>> console output: https://syzkaller.appspot.com/x/log.txt?x=177d8bfcb00000 >>>> >>>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>>> Reported-by: syzbot+b86736b5935e0d25b446@syzkaller.appspotmail.com >>>> Fixes: 22849b5ea595 ("devlink: Remove not-executed trap policer notifications") >>>> >>>> ================================================================== >>>> BUG: KASAN: slab-out-of-bounds in memcpy include/linux/fortify-string.h:225 [inline] >>>> BUG: KASAN: slab-out-of-bounds in copy_data+0xf3/0x2e0 drivers/char/hw_random/virtio-rng.c:68 >>>> Read of size 64 at addr ffff88801a7a1580 by task syz-executor989/6542 >>>> >>> >>> I'm not able to reproduce the problem with next-20211026 and the C reproducer. >>> >>> And reviewing the code in copy_data() I don't see any issue. >>> >>> Is it possible to know what it the VM configuration used to test it? >> >> Hi Laurent, >> >> syzbot used e2-standard-2 GCE VM when that happened. >> You can see some info about these VMs under the "VM info" link on the dashboard. > > Could you pls confirm whether reverting > caaf2874ba27b92bca6f0298bf88bad94067ec37 addresses this? > I've restarted the syzbot on top of "hwrng: virtio - don't wait on cleanup" [1] and the problem has not been triggered. See https://syzkaller.appspot.com/bug?extid=b86736b5935e0d25b446 Thanks, Laurent [1] d721abbeb145 hwrng: virtio - don't wait on cleanup bb768beb0a5f hwrng: virtio - add an internal buffer d25f27432f80 (origin/master, origin/HEAD, master) Merge tag 'arm-soc-fixes-5.15-3' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc