From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756233AbdCUDyX (ORCPT ); Mon, 20 Mar 2017 23:54:23 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:35906 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbdCUDyU (ORCPT ); Mon, 20 Mar 2017 23:54:20 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a38-f79f06d000001a72-0b-58d0a3e9b9e2 Content-transfer-encoding: 8BIT Message-id: <58D0A3E8.6090609@samsung.com> Date: Tue, 21 Mar 2017 12:54:16 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , Hans de Goede , "Rafael J . Wysocki" , Len Brown , Wolfram Sang , Lee Jones , Sebastian Reichel , MyungJoo Ham Cc: linux-acpi@vger.kernel.org, Takashi Iwai , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver In-reply-to: <1490014841.19767.106.camel@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEJsWRmVeSWpSXmKPExsWy7bCmnu7LxRciDC4ulbbobZrOZPHmOJC4 //Uoo8XOh2/ZLJbv62e06Pj7hdHi8q45bBafe48wWtxuXMFmceb0JVaL07tLLF5ufsNksfLE LGYHXo9NqzrZPO5c28PmMe9koMf7fVfZPLZcbWfx6NuyitFj8+lqj5OnnrB4fN4kF8AZlWqT kZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3S1kkJZYk4p UCggsbhYSd/Opii/tCRVISO/uMRWKdrQ0EjP0MBcz8jISM/EONbKyBSoJCE14/+G46wFS7kr OmdvYm1g/MPRxcjJISFgItH+ahIbhC0mceHeeiCbi0NIYAejxJS/N5ghnHYmiSVnDrDCdHze 8I8JIjGHUWLb5u1g7bwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoCnx4sskFoj6e4wSX3dOZoeo 15KY//8YG0g9i4CqxMwjGiBhNqDw/hc3wEbyCyhKXP3xmBHEFhWIkNg5/xs7yBwRgT1MEq3b X4I5zAKTGSVuH58NViUskCzxaNV7JhCbU8BS4vmKXYwQV/9llzi8xwhkmYSArMSmA8wQYReJ V0f6WCBsYYlXx7ewQ9jSEqv+3QJ7UkKgnVFi85x7LBBOB6PE/ZWN0KAwlrj/4B4zxJt8Eu++ 9rBCLOCV6GgTgijxkGhdfAKq3FFi6rnXYLaQQCeTxNsLERMYFWYhhd0sRNjNQgq7BYzMqxjF UguKc9NTiw0LTPSKE3OLS/PS9ZLzczcxgtOvlsUOxj3nfA4xCnAwKvHwrrhyPkKINbGsuDL3 EKMEB7OSCK9r34UIId6UxMqq1KL8+KLSnNTiQ4ymwKCfyCwlmpwPzA15JfGGJmaGJkYmhobm RgZGSuK8rAYTI4QE0hNLUrNTUwtSi2D6mDg4pRoYHYyPiKUdSnFK3F+0PrGhylVWzWOKXObM ucdEliyZ0/DqmSBfXoWN+Ex+p38cG1vuxk87lxAu5xUqmHfm/g3J0/v6BPRkdl0/Njn1/pzp yn6LlZ5PWLfIfpU5q1mnIy9D8f/f0VOP+dg/OcPL4VX9NnJ9Hnf4/ap2wxX2u5Q57njuV6q6 mayhxFKckWioxVxUnAgAgaEyo9UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQd2Xiy9EGEz7ymjR2zSdyeLNcSBx /+tRRoudD9+yWSzf189o0fH3C6PF5V1z2Cw+9x5htLjduILN4szpS6wWp3eXWLzc/IbJYuWJ WcwOvB6bVnWyedy5tofNY97JQI/3+66yeWy52s7i0bdlFaPH5tPVHidPPWHx+LxJLoAzys0m IzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2 CW4Z/zccZy1Yyl3ROXsTawPjH44uRk4OCQETic8b/jFB2GISF+6tZ+ti5OIQEpjFKPF/ynmw BK+AoMSPyfdYuhg5OJgF5CWOXMqGMNUlpkzJhSh/wCgx7cx/qHItifn/j7GB1LAIqErMPKIB EmYDCu9/cYMNxOYXUJS4+uMxI0iJqECERPeJSpAxIgJ7mCTetF1hB3GYBSYzSrRt/MEM0iAs kCwxteEQI8SyTiaJiZ/Pgi3jFLCUeL5iF+MERsFZSE6dhXDqLIRTFzAyr2KUSC1ILihOSs81 zEst1ytOzC0uzUvXS87P3cQIjupnUjsYD+5yP8QowMGoxMO74sr5CCHWxLLiytxDjBIczEoi vK59FyKEeFMSK6tSi/Lji0pzUosPMZoC/TqRWUo0OR+YcPJK4g1NzE3MjQ0szC0tTYyUxHkb Zz8LFxJITyxJzU5NLUgtgulj4uCUamB0Xqsr5PiA1Sfvw92e36uv9HdsVvmW8C3z8RHfN7N8 3T4yz8+o4FjP1Fd0if1xlOo/Q+4HK1uvcjvUKuaKFv6qOxz5fb3W3znzC6w+n3q29f+Hh8bH 7sTsLgzIXGuc07mdXUmcoeN6l0H2TBXjPcG2/9sfMSgU/Jhk8WTmt8PBV9dIan066c+mxFKc kWioxVxUnAgAXVekVAADAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170321035417epcas1p4955a87609c674c50363175358cd995a4 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 X-RootMTR: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 References: <20170317095527.10487-1-hdegoede@redhat.com> <20170317095527.10487-4-hdegoede@redhat.com> <58CF3183.4090101@samsung.com> <1490014841.19767.106.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 03월 20일 22:00, Andy Shevchenko wrote: > On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >> On 2017년 03월 17일 18:55, Hans de Goede wrote: > >>> +static const struct platform_device_id cht_wc_extcon_table[] = { >>> + { .name = "cht_wcove_pwrsrc" }, >> >> You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. >> So, To maintain the consistency, you better to use the 'cht-wc' as the >> name. >> - I prefer to use '-' instead of '_' in the name. >> .name ="cht-wc" > > I would keep as Hans did for the sake of consistency among all Whiskey > Cove device drivers (and predecessors like Crystal Cove). The 'wcove' short word is not used in this patch. If the author want to use the 'wcove', I recommend that you should use the 'wcove' instead of 'wc' in this patch. And, I think that 'pwrsrc' is not ambiguous. Hans might use the 'pwrsrc' as the 'Power Source'. But, this driver is not power source. Instead, this driver supports the detection of external connector. I think 'power source' means the power supply instead of detector. > > I understand your point from extcon subsystem view, but PMICs like > Whiskey Cove are multi-functional devices, and thus naming across them > (same prefix in use to be precise) is better idea. > >> >>> + {}, >>> +}; >>> +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table); > -- Best Regards, Chanwoo Choi Samsung Electronics