From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756344AbdCUFVx (ORCPT ); Tue, 21 Mar 2017 01:21:53 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:58087 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656AbdCUFVt (ORCPT ); Tue, 21 Mar 2017 01:21:49 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a58-f79f16d00000132c-0b-58d0b86a94e1 Content-transfer-encoding: 8BIT Message-id: <58D0B868.6060602@samsung.com> Date: Tue, 21 Mar 2017 14:21:44 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , Hans de Goede , "Rafael J . Wysocki" , Len Brown , Wolfram Sang , Lee Jones , Sebastian Reichel , MyungJoo Ham Cc: linux-acpi@vger.kernel.org, Takashi Iwai , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver In-reply-to: <58D0A3E8.6090609@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEJsWRmVeSWpSXmKPExsWy7bCmlm7WjgsRBse2C1v0Nk1nsnhzHEjc /3qU0WLnw7dsFsv39TNadPz9wmhxedccNovPvUcYLW43rmCzOHP6EqvF6d0lFi83v2GyWHli FrMDr8emVZ1sHneu7WHzmHcy0OP9vqtsHluutrN49G1Zxeix+XS1x8lTT1g8Pm+SC+CMSrXJ SE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpaSaEsMacU KBSQWFyspG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCace/NFsaCmzwV D5qkGxjbuLoYOTkkBEwkLmz8xQphi0lcuLeerYuRi0NIYCmjxMuJhxlBEkIC7UwSy2eEwTRM PHucHaJoOaPE220H2UASvAKCEj8m32PpYuTgYBaQlzhyKRskzCygKfHiyyQWiPp7jBLHj05g gajXkljS3wtmswioSjzdeAnsCjag+P4XN8Bm8gsoSlz98RjsCFGBCImd87+BLRYR2MMk0br9 JZjDLDCZUeL28dlgVcICyRKPVr1nArmCU0Bb4kZbEkiNhMBfdokVnbfB4hICshKbDjBDfOMi 8eDiP6j3hSVeHd/CDmFLS/xdeosRoredUWLznHssEE4Ho8T9lY1QHcYS9x/cY4b4k0+i9/cT qAW8Eh1tQhAlHhKti09AlTtKTD33mhUSFCuYJNqPnmCZwKgwCyn0ZiFCbxZS6C1gZF7FKJZa UJybnlpsWmCiV5yYW1yal66XnJ+7iRGcfrUidjD+mxF0iFGAg1GJh3dGzIUIIdbEsuLK3EOM EhzMSiK8rn1AId6UxMqq1KL8+KLSnNTiQ4ymwMCfyCwlmpwPzA15JfGGJmaGJkaWQGhuaK4k zhtlMDFCSCA9sSQ1OzW1ILUIpo+Jg1OqgbE+odO/Y933ZyIR5yKfn9m2TlHaJ+7iAqbfWTG/ zeaftFJjDs5SO3xXSOlNdxv3tHvH1pnZi5vO652UlHjkQBLHJdbwm8tZyvi/v3751Nubge31 rKu/w7YcfHR+2sW4G6c3/Fwi0Gx4bPYyn8MKTo7d8UpqNk9L+/17679E+tyddc9t6ymfxY+V WIozEg21mIuKEwF3kbjn1QMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t9jAd3MHRciDI7OELLobZrOZPHmOJC4 //Uoo8XOh2/ZLJbv62e06Pj7hdHi8q45bBafe48wWtxuXMFmceb0JVaL07tLLF5ufsNksfLE LGYHXo9NqzrZPO5c28PmMe9koMf7fVfZPLZcbWfx6NuyitFj8+lqj5OnnrB4fN4kF8AZ5WaT kZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27 BLeMe2+2MBbc5Kl40CTdwNjG1cXIySEhYCIx8exxdghbTOLCvfVsXYxcHEICSxklvv+fxwiS 4BUQlPgx+R5LFyMHB7OAvMSRS9kQprrElCm5EOUPGCWOnZ7CDlGuJbGkv5cFxGYRUJV4uvES K4jNBhTf/+IGG4jNL6AocfXHY0aQOaICERLdJypB5ogI7GGSeNN2hR3EYRaYzCjRtvEHM0iD sECyxNSGQ4wQ21YwSbzcvBism1NAW+JGW9IERsFZSE6dhXDqLIRTFzAyr2KUSC1ILihOSs81 ykst1ytOzC0uzUvXS87P3cQIjuln0jsYD+9yP8QowMGoxMO74sr5CCHWxLLiytxDjBIczEoi vK59FyKEeFMSK6tSi/Lji0pzUosPMZoC/TqRWUo0OR+YbvJK4g1NzE3MjQ0szC0tTYyUxHkb Zz8LFxJITyxJzU5NLUgtgulj4uCUamCcePFMdRtHb57D8fntZwPmFJ77Z7GdN1nhUn2KcLLG daaMZxIzTqnF177UkLmtu130cs/+mvUB/wW3bXPdWFi6bb7qgTLTXvWcvWcX/At1eRdS0HTj 2RcWq7vq4qoSgq2hJx6Z3rp4VJVjY3L6tjMb5af9NHNqn3pxY4tGT933f6dPLQg43sOlxFKc kWioxVxUnAgAiVpXp/8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170321052145epcas5p3f76c5f6ec678c6de6dae45c3369fa4f8 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 X-RootMTR: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 References: <20170317095527.10487-1-hdegoede@redhat.com> <20170317095527.10487-4-hdegoede@redhat.com> <58CF3183.4090101@samsung.com> <1490014841.19767.106.camel@linux.intel.com> <58D0A3E8.6090609@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 03월 21일 12:54, Chanwoo Choi wrote: > On 2017년 03월 20일 22:00, Andy Shevchenko wrote: >> On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >>> On 2017년 03월 17일 18:55, Hans de Goede wrote: >> >>>> +static const struct platform_device_id cht_wc_extcon_table[] = { >>>> + { .name = "cht_wcove_pwrsrc" }, >>> >>> You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. >>> So, To maintain the consistency, you better to use the 'cht-wc' as the >>> name. >>> - I prefer to use '-' instead of '_' in the name. >>> .name ="cht-wc" >> >> I would keep as Hans did for the sake of consistency among all Whiskey >> Cove device drivers (and predecessors like Crystal Cove). > > The 'wcove' short word is not used in this patch. > If the author want to use the 'wcove', I recommend that > you should use the 'wcove' instead of 'wc' in this patch. > > And, I think that 'pwrsrc' is not ambiguous. I'm sorry. I used the wrong word. I mean that 'pwrsrc' is not correct. > Hans might use the 'pwrsrc' as the 'Power Source'. > But, this driver is not power source. Instead, > this driver supports the detection of external connector. > > I think 'power source' means the power supply instead of detector. > >> >> I understand your point from extcon subsystem view, but PMICs like >> Whiskey Cove are multi-functional devices, and thus naming across them >> (same prefix in use to be precise) is better idea. >> >>> >>>> + {}, >>>> +}; >>>> +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table); >> > > -- Best Regards, Chanwoo Choi Samsung Electronics