From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756555AbdCUG2p (ORCPT ); Tue, 21 Mar 2017 02:28:45 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:35319 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755783AbdCUG1X (ORCPT ); Tue, 21 Mar 2017 02:27:23 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a58-f79f16d00000132c-56-58d0c7c73ae1 Content-transfer-encoding: 8BIT Message-id: <58D0C7C6.1090008@samsung.com> Date: Tue, 21 Mar 2017 15:27:18 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , Hans de Goede , "Rafael J . Wysocki" , Len Brown , Wolfram Sang , Lee Jones , Sebastian Reichel , MyungJoo Ham Cc: linux-acpi@vger.kernel.org, Takashi Iwai , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver In-reply-to: <58D0B868.6060602@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMJsWRmVeSWpSXmKPExsWy7bCmuu7x4xciDN7sEbfobZrOZPHmOJC4 //Uoo8XOh2/ZLJbv62e06Pj7hdHi8q45bBafe48wWtxuXMFmceb0JVaL07tLLF5ufsNksfLE LGYHXo9NqzrZPO5c28PmMe9koMf7fVfZPLZcbWfx6NuyitFj8+lqj5OnnrB4fN4kF8AZlWqT kZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3S1kkJZYk4p UCggsbhYSd/Opii/tCRVISO/uMRWKdrQ0EjP0MBcz8jISM/EONbKyBSoJCE143h7N0vBB76K ZX/PsjYwPuXuYuTkkBAwkZhzcg8rhC0mceHeerYuRi4OIYGljBJvP6xnhHDamSTuv1nMAtOx 6ONqJojEckaJ5ksrwNp5BQQlfky+B1TEwcEsIC9x5FI2SJhZQFPixZdJLBD19xglni+/xQZR ryUxeWE32FAWAVWJox//M4PYbEDx/S9ugNXwCyhKXP3xmBHEFhWIkNg5/xs7yCARgT1MEq3b X4I5zAKTGSVuH58NViUskCzxaNV7JpArOAW0Je7dNQOpkRD4yS7RtXoGK0hcQkBWYtMBZohv XCTuP/wDZQtLvDq+hR3Clpb4u/QWI0RvO6PE5jn3WCCcDkaJ+ysboSFmLHH/wT1miD/5JHp/ P2GCWMAr0dEmBFHiIdG6+ARUuaPE1HOvwWwhgZNMErsvc01gVJiFFHizEIE3CynwFjAyr2IU Sy0ozk1PLTYtMNErTswtLs1L10vOz93ECE7AWhE7GP/NCDrEKMDBqMTDOyPmQoQQa2JZcWXu IUYJDmYlEV7XPqAQb0piZVVqUX58UWlOavEhRlNg2E9klhJNzgdmh7ySeEMTM0MTI0sgNDc0 VxLnjTKYGCEkkJ5YkpqdmlqQWgTTx8TBKdXA2PJpfc2ME9/dL6zvNtoiK3IxxUT5/XPep7zL Cr0q9N53a/EeDt7rP39haabTtYoqxst7r4ZO2p8/Q7tX5Ubp1iUcrzsDA9zUc9PdHzevnadk KNidITT580pesRvs4uW7ufksu2R5nsQu2GbFvudMnlKa9rOpt8peK5xm8Vhb93p5Ya0zx8Mj SizFGYmGWsxFxYkAMVFQ2tYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jAd1jxy9EGHy8K2PR2zSdyeLNcSBx /+tRRoudD9+yWSzf189o0fH3C6PF5V1z2Cw+9x5htLjduILN4szpS6wWp3eXWLzc/IbJYuWJ WcwOvB6bVnWyedy5tofNY97JQI/3+66yeWy52s7i0bdlFaPH5tPVHidPPWHx+LxJLoAzys0m IzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2 CW4Zx9u7WQo+8FUs+3uWtYHxKXcXIyeHhICJxKKPq5kgbDGJC/fWs3UxcnEICSxllPjY8ZAF JMErICjxY/I9IJuDg1lAXuLIpWwIU11iypRciPIHjBIn5k2DKteSmLywG8xmEVCVOPrxPzOI zQYU3//iBhuIzS+gKHH1x2NGkDmiAhES3ScqQeaICOxhknjTdoUdxGEWmMwo0bbxB1izsECy xNSGQ4wQ204ySRw+084M0s0poC1x767ZBEbBWUhOnYVw6iyEUxcwMq9ilEgtSC4oTkrPNcpL LdcrTswtLs1L10vOz93ECI7qZ9I7GA/vcj/EKMDBqMTDu+LK+Qgh1sSy4srcQ4wSHMxKIryu fRcihHhTEiurUovy44tKc1KLDzGaAv06kVlKNDkfmHDySuINTcxNzI0NLMwtLU2MlMR5G2c/ CxcSSE8sSc1OTS1ILYLpY+LglGpgZF7WPWnLyndLX4Qbhjjnbojfk9W6OPxB+YfifGdmTd4o u3N8xr9CsrOSeA6a5ez3ruEy2P7vTKJrh77S5f81LR6lDPHnLvCzGVk5m03ZvUxmu9nVAhkX CdGp9rONDVs02hX9Jm5i7/tv5eWXOHVt1A8ps9r5fjuLi6Z7cH+tm3OqSDGNwU+JpTgj0VCL uag4EQD8nYKxAAMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170321062718epcas5p1afed586db0ee7be8b2b34039345dcf5d X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 X-RootMTR: 20170317095544epcas5p42dd4115627c9cf9de3911b433024ac93 References: <20170317095527.10487-1-hdegoede@redhat.com> <20170317095527.10487-4-hdegoede@redhat.com> <58CF3183.4090101@samsung.com> <1490014841.19767.106.camel@linux.intel.com> <58D0A3E8.6090609@samsung.com> <58D0B868.6060602@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I think it again. The "cht_wcove_pwrsrc' is ok, if the register use the 'pwrsrc' word and using the 'wcove' instead of 'wc'. It is not big matter. I agree to use the 'cht_wcove_pwrsrc'. Best Regards, Chanwoo Choi On 2017년 03월 21일 14:21, Chanwoo Choi wrote: > On 2017년 03월 21일 12:54, Chanwoo Choi wrote: >> On 2017년 03월 20일 22:00, Andy Shevchenko wrote: >>> On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote: >>>> On 2017년 03월 17일 18:55, Hans de Goede wrote: >>> >>>>> +static const struct platform_device_id cht_wc_extcon_table[] = { >>>>> + { .name = "cht_wcove_pwrsrc" }, >>>> >>>> You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'. >>>> So, To maintain the consistency, you better to use the 'cht-wc' as the >>>> name. >>>> - I prefer to use '-' instead of '_' in the name. >>>> .name ="cht-wc" >>> >>> I would keep as Hans did for the sake of consistency among all Whiskey >>> Cove device drivers (and predecessors like Crystal Cove). >> >> The 'wcove' short word is not used in this patch. >> If the author want to use the 'wcove', I recommend that >> you should use the 'wcove' instead of 'wc' in this patch. >> >> And, I think that 'pwrsrc' is not ambiguous. > > I'm sorry. I used the wrong word. I mean that 'pwrsrc' is not correct. > >> Hans might use the 'pwrsrc' as the 'Power Source'. >> But, this driver is not power source. Instead, >> this driver supports the detection of external connector. >> >> I think 'power source' means the power supply instead of detector. >> >>> >>> I understand your point from extcon subsystem view, but PMICs like >>> Whiskey Cove are multi-functional devices, and thus naming across them >>> (same prefix in use to be precise) is better idea. >>> >>>> >>>>> + {}, >>>>> +}; >>>>> +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table); >>> >> >> > >