From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbdCUIBv (ORCPT ); Tue, 21 Mar 2017 04:01:51 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:10735 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755004AbdCUIBt (ORCPT ); Tue, 21 Mar 2017 04:01:49 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="16799969" Subject: Re: [PATCH] vfio pci: kernel support of error recovery only for non fatal error To: Alex Williamson References: <1488180523-18137-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20170313160619.28622002@t450s.home> <58CFD01F.1060508@cn.fujitsu.com> <20170320083056.3f2a5603@t450s.home> CC: , , , , From: Cao jin Message-ID: <58D0DEC8.6080507@cn.fujitsu.com> Date: Tue, 21 Mar 2017 16:05:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20170320083056.3f2a5603@t450s.home> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.69] X-yoursite-MailScanner-ID: 5607049FD503.A5899 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2017 10:30 PM, Alex Williamson wrote: > On Mon, 20 Mar 2017 20:50:39 +0800 > Cao jin wrote: > >> Sorry for late. >> >> On 03/14/2017 06:06 AM, Alex Williamson wrote: >>> On Mon, 27 Feb 2017 15:28:43 +0800 >>> Cao jin wrote: >>> >>>> 0. What happens now (PCIE AER only) >>>> Fatal errors cause a link reset. >>>> Non fatal errors don't. >>>> All errors stop the VM eventually, but not immediately >>>> because it's detected and reported asynchronously. >>>> Interrupts are forwarded as usual. >>>> Correctable errors are not reported to guest at all. >>>> Note: PPC EEH is different. This focuses on AER. >>> >>> Perhaps you're only focusing on AER, but don't the error handlers we're >>> using support both AER and EEH generically? I don't think we can >>> completely disregard how this affects EEH behavior, if at all. >>> >> >> After taking a rough look at the EEH, find that EEH always feed >> error_detected with pci_channel_io_frozen, from perspective of >> error_detected, EEH is not affected. >> >> I am not sure about a question: when assign devices in spapr host, >> should all functions/devices in a PE be bound to vfio? I am kind of >> confused about the relationship between a PE & a tce iommu group > > AIUI, yes all devices within the PE are part of the same IOMMU group > and therefore all endpoints must be bound to vfio or pci-stub. > Thanks. Then I think this approach won't affect EEH. I was considering the same issue you mentioned for slot_reset may affect EEH, but if they all must be bound to vfio, seems the issue won't happen to EEH. -- Sincerely, Cao jin