mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Lawrence <t4rmin@zohomail.com>
To: Nam Cao <namcaov@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank space
Date: Sun, 23 Oct 2022 16:05:50 +0700	[thread overview]
Message-ID: <58a34e59c75e2f9fbb918d632590f3115a585bfc.camel@zohomail.com> (raw)
In-Reply-To: <20221022182100.GA16464@nam-dell>

On Sat, 2022-10-22 at 20:21 +0200, Nam Cao wrote:
> On Sat, Oct 22, 2022 at 10:48:08PM +0700, Aaron Lawrence wrote:
> > > From e6635103e3cf2426220767955b99d2e2b62a7329 Mon Sep 17 00:00:00 2001
> > Message-Id: <e6635103e3cf2426220767955b99d2e2b62a7329.1666450553.git.t4rmin@zohomail.com>
> > In-Reply-To: <cover.1666450553.git.t4rmin@zohomail.com>
> > References: <cover.1666450553.git.t4rmin@zohomail.com>
> > From: Aaron Lawrence <t4rmin@zohomail.com>
> > Date: Sat, 22 Oct 2022 20:46:25 +0700
> 
> I think you messed up something here. These are not supposed to be in
> the email description. All your patches are sent separatedly, instead of
> being in the same thread.
> 
> I can recommend follow the instructions in this website:
> https://kernelnewbies.org/FirstKernelPatch
> 
> > Subject: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank
> >  space
> > 
> > Added a missing blank space as per the Linux kernel coding-style
> > regulations. The issue was flagged by the checkpatch script as a
> > warning.
> > 
> > Signed-off-by: Aaron Lawrence <t4rmin@zohomail.com>
> > ---
> >  drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > index ef3dca51cf99..b763cf0ba356 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > @@ -70,6 +70,7 @@ static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
> >  void HTUpdateDefaultSetting(struct rtllib_device *ieee)
> >  {
> >  struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
> > +
> >  pHTInfo->bRegShortGI20MHz = 1;
> >  pHTInfo->bRegShortGI40MHz = 1;
> > -- 
> > 2.38.1
> > 
> > 

Ah, I see. I (hopefully) will be sending the correct email 
patchset format next time. Thanks.

Aaron

  reply	other threads:[~2022-10-23  9:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 15:48 Aaron Lawrence
2022-10-22 18:21 ` Nam Cao
2022-10-23  9:05   ` Aaron Lawrence [this message]
2022-10-22 20:08 ` Slade Watkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58a34e59c75e2f9fbb918d632590f3115a585bfc.camel@zohomail.com \
    --to=t4rmin@zohomail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=namcaov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®