From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46CFA3B42D6 for ; Fri, 10 Jul 2026 09:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783677215; cv=none; b=aHRjtFrLTAVBqlgQNsOOVBrJs2ilPxkgZIC+bTD5DsEJUagdqVL2YOcykrS1D3SAoRjWM6eBgpyup/CpPwmACzp3misYF6IaLyeoYKmym1lZk9VWCqF1FmGOOB07GT/iYdDz1R0S/XgMFrXhbZDoUt6u77fysk+iWE80SkNbous= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783677215; c=relaxed/simple; bh=IPotQd9/0KdPhm5+/ZiEJ1zpHdGt8sKV9oR6K/Crj6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VhSGL0xlehnXq1lWm3dB4+6ZrCbkJueyk65j7+o69F9neSeGztqUwktMgjewvNokoEHLSLhvd2j7AEOsez54Iykr0YVtf287BldUtzyMollJYyoEL24c9TYkx2PF3jk6w8EPOYSCBa6xvU542T6kZ8CfdDbrOWxszIgGCEuq1zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gRcneR0y; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gRcneR0y" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493ba701891so5819365e9.3 for ; Fri, 10 Jul 2026 02:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783677213; x=1784282013; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r2vMl6TMTZInWK5MDvh/DgoAE2fsUyLxxIJImnW4fyo=; b=gRcneR0yHLdGTmXrsWqZovDGL+gsoXRDR6558HVpA92PIaTvgPiB5ZnYN5axXTj7k2 23G0wKGr1XcPEgPg0sExrb09pK7MxsRWIc5cvy0h7MdZjGc2BbmdCOysPaG2nye/1FSt 2XRO13YPUBGfXnTDGoOpHOpMSluClvZvSfMfK39k0Jl1B1fAMf7BgIZGspe1rCC5qlGr PsincUytNn+N0cNkiZAF5z801V4O+0J+snS8OqfomxED2OR6lGJ7tWGElBo+tpFpGjht PkW01q2avyeSW7V91/U0W4NjBo+zbvBIDYgmSiq5lRfvxzul0gDufIVlseeotHE5DdO4 GubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783677213; x=1784282013; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r2vMl6TMTZInWK5MDvh/DgoAE2fsUyLxxIJImnW4fyo=; b=FVq+0FOh0LR5YXp/uqZliQNJf1OWsxMAL490HWbrRfk1/fqFRVmFgXnue2xF582HnF lsyLDxMi0i7V/R6xywtFwMI+3q+/n8BH2B4zy+BLMvgAftuDcOfYxxP1tHXuD2dmjvTp xRqqEcBRxYUQkQ2YQf+bwqjxIpdIa5JQgD+U5i2RCk+8nqa3W6dQnlLvAx3UrVCnTShN gX0amKoxuGYYkTBSN1HajYlj05Lmzla5JLAETu+iojbuXfQbm+bzjwF6frsCKWy/Cvay aKXi9SPeug8yih7uQ6qf8KI56q9fPuYIm/UzubP0gDp9lxRhoqY2XJCuQW9N5m6HeTyB Qs+A== X-Forwarded-Encrypted: i=1; AHgh+Ro0cKlpTKfYB6lxKmCtW79QOoHEmNB4ANcEeKUbBXa20Lgsqy8u60Tb77DNyj9ZuHeZCPqY8qtkXHwdx98=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7LmQX7/ewQLBuAvEq0y65T23QplJYgK5tv6qDfTorm0l7pzVj XOiSye6YEovTLi/HdKM3FN8CUsHjPRbsRCW/ofj19W3RyUhx5uGGto8Lhu4etKFOwHc= X-Gm-Gg: AfdE7clU8HO05UobNcwRCSGNeY/hbpqbgmxv/yENlXyNTF6Dm8/mUlAnEHLuhXh9s9W pB9XbTx+cxB/NsZvalbAdvF7JvXhWYyw/g1U1//Wxq/K4aH1tVjRAuSphnM3r3EGapXW3SGCNUC kLe4PWu5VmW4j55uExITKNXQ2gZBFU3m7ADNCoeUPD27AXOaBK623GbzqJ6w+gv4S5cIE6CIK5D yXt9B0TJ+MVPJOmqvHSZFNbEp+5/82M6VYAlsJI5Cw428T2UJQoqZwNag+my3yYIMEsiU1yOUzs Sjuv44UEHRenIDq62nlDl+ZtgfH5iApgKmdc4ETvLbLd6XUae8FRtqbOU+o7FJchBG81hDX8EpF nRALvbDg8DP7JEvRwNirbQXvbOG4bWMVmkXtNwf/dIFyg4LVU79oyKWhrpQ6g2N55k/P+2e1v8V 5LXogdRXB+n2Bt8RcX2BgJ8bUnya7fPI01Sl8jrPkUzxKK3bkZK36r X-Received: by 2002:a05:600c:821a:b0:493:a570:df7d with SMTP id 5b1f17b1804b1-493e68bef51mr108059485e9.20.1783677212605; Fri, 10 Jul 2026 02:53:32 -0700 (PDT) Received: from ?IPV6:2001:a61:139c:4201:d685:3a99:8468:482? ([2001:a61:139c:4201:d685:3a99:8468:482]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f3a60404sm39143655e9.1.2026.07.10.02.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 02:53:32 -0700 (PDT) Message-ID: <58b55e55-652a-498a-8f36-145d9ad58e9e@suse.com> Date: Fri, 10 Jul 2026 11:53:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: misc: cypress_cy7c63: check control transfer status To: Keshav Verma , Greg KH Cc: johan@kernel.org, kees@kernel.org, o.bock@fh-wolfenbuettel.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260618203053.4725-1-iganschel@gmail.com> <2026070835-thorn-doable-8c28@gregkh> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.07.26 01:30, Keshav Verma wrote: > read_port() currently ignores errors from vendor_command() and always > returns the cached port value. This can report stale data when the USB > control transfer fails or returns a short response. > > Convert vendor_command() to usb_control_msg_recv(), which returns 0 on > success and a negative errno on failure, and propagate transport errors > from read_port() instead of returning cached data. Hi, Thank you for making a patch for this issue. I am sorry, but this approach mixes issues that are real with something that is not a problem. > Fixes: 9189bfc2df0f ("[PATCH] USB: rename Cypress CY7C63xxx driver to > proper name and fix up some tiny things") > Signed-off-by: Keshav Verma > --- > v2: > - retval = usb_control_msg(dev->udev, pipe, request, > - USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER, > - address, data, iobuf, CYPRESS_MAX_REQSIZE, > - USB_CTRL_GET_TIMEOUT); This does return errors. > - /* we must not process garbage */ > - if (retval < 2) > + dev_dbg(&dev->udev->dev, "Sending usb_control_msg_recv (data: > %d)\n", data); > + > + retval = usb_control_msg_recv(dev->udev, 0, request, There is no point in this change. You just allocate yet another buffer for no gain. Regards Oliver