mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chi Zhiling <chizhiling@163.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: exfat@lists.linux.dev, linux-kernel@vger.kernel.org,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Yuezhang Mo <yuezhang.mo@sony.com>,
	Chi Zhiling <chizhiling@kylinos.cn>
Subject: Re: [PATCH] exfat: clear the volume dirty flag only when remounting read-only
Date: Fri, 4 Sep 2026 09:46:33 +0800	[thread overview]
Message-ID: <58bcfcdf-167a-4553-bfcd-cd576e9379b0@163.com> (raw)
In-Reply-To: <CAKYAXd-YoYZfNGDJs1gjJPHZ4n5oe+r93y32Gyb=p8rUxzDeqg@mail.gmail.com>

On 9/4/26 7:28 AM, Namjae Jeon wrote:
>> diff --git a/fs/exfat/super.c b/fs/exfat/super.c
>> index a9ea36ba2693..268732571837 100644
>> --- a/fs/exfat/super.c
>> +++ b/fs/exfat/super.c
>> @@ -775,9 +775,12 @@ static int exfat_reconfigure(struct fs_context *fc)
>>          fc->sb_flags |= SB_NODIRATIME;
>>
>>          sync_filesystem(sb);
>> -       mutex_lock(&sbi->s_lock);
>> -       exfat_clear_volume_dirty(sb);
>> -       mutex_unlock(&sbi->s_lock);
>> +
>> +       if ((fc->sb_flags & (SB_FORCE | SB_RDONLY)) == SB_RDONLY) {
> Could we also add !sb_rdonly(sb) here?
>              if ((fc->sb_flags & (SB_FORCE | SB_RDONLY)) == SB_RDONLY &&
>                   !sb_rdonly(sb))

Yes, this way we do not call exfat_clear_volume_dirty() when remounting 
from RO to RO. I will update it in v2.

Thanks.



      reply	other threads:[~2026-09-04  1:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:26 Chi Zhiling
2026-09-03 23:28 ` Namjae Jeon
2026-09-04  1:46   ` Chi Zhiling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58bcfcdf-167a-4553-bfcd-cd576e9379b0@163.com \
    --to=chizhiling@163.com \
    --cc=chizhiling@kylinos.cn \
    --cc=exfat@lists.linux.dev \
    --cc=linkinjeon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®