From: Paolo Abeni <pabeni@redhat.com>
To: Bernard Zhao <zhaojunkui2008@126.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bernard Zhao <bernard@vivo.com>
Subject: Re: [PATCH] ethernet/ti: delete if NULL check befort devm_kfree
Date: Thu, 12 May 2022 10:47:35 +0200 [thread overview]
Message-ID: <58c647040b4a9500c687f9a3dd3d8ca8fc1c4cbb.camel@redhat.com> (raw)
In-Reply-To: <20220511072512.666863-1-zhaojunkui2008@126.com>
On Wed, 2022-05-11 at 00:25 -0700, Bernard Zhao wrote:
> devm_kfree check the point, there is no need to check before
> devm_kfree call.
> This change is to cleanup the code a bit.
>
> Signed-off-by: Bernard Zhao <zhaojunkui2008@126.com>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
The patch looks good, but the somewhat strange From: header is
confusing pw and you probably want to drop one of the SoB above, please
re-send, thanks!
Paolo
next prev parent reply other threads:[~2022-05-12 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 7:25 Bernard Zhao
2022-05-12 8:47 ` Paolo Abeni [this message]
2022-05-16 1:52 Bernard Zhao
2022-05-17 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c647040b4a9500c687f9a3dd3d8ca8fc1c4cbb.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=bernard@vivo.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhaojunkui2008@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®