mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: info@a-wing.co.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: sis5513.c patch take 2
Date: Thu, 9 Jun 2005 14:33:52 +0200	[thread overview]
Message-ID: <58cb370e0506090533362dfbf0@mail.gmail.com> (raw)
In-Reply-To: <42A831E3.5080607@a-wing.co.uk>

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi,

On 6/9/05, Andrew Hutchings <info@a-wing.co.uk> wrote:
> Hi,
> 
> Is this patch safer?  I am burn-in testing it now and it seems work fine
> with UDMA transfers.  I added the PCI ID of the northbridge as suggested.

Thanks, could you also try this simple debugging patch?
[ without applying your patch ]

It may be possible to add generic 965L support just like 962/936L one
(also NorthBridge<->SouthBridge mapping is not unique nowadays).

Bartlomiej

[-- Attachment #2: sis5513-debug1.patch --]
[-- Type: application/octet-stream, Size: 457 bytes --]

--- a/drivers/ide/pci/sis5513.c	2005-05-26 14:51:14.000000000 +0200
+++ b/drivers/ide/pci/sis5513.c	2005-06-09 14:19:44.000000000 +0200
@@ -765,6 +765,8 @@
 			pci_read_config_word(dev, PCI_DEVICE_ID, &trueid);
 			pci_write_config_dword(dev, 0x54, idemisc);
 
+			printk(KERN_INFO "SIS5513: trueid=0x%x\n", trueid);
+
 			if (trueid == 0x5518) {
 				printk(KERN_INFO "SIS5513: SiS 962/963 MuTIOL IDE UDMA133 controller\n");
 				chipset_family = ATA_133;

  reply	other threads:[~2005-06-09 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09 12:11 Andrew Hutchings
2005-06-09 12:33 ` Bartlomiej Zolnierkiewicz [this message]
2005-06-09 13:05   ` Andrew Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e0506090533362dfbf0@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=info@a-wing.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®