mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-ide@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] Incorrect device link for ide-cs
Date: Thu, 3 Nov 2005 10:57:15 +0100	[thread overview]
Message-ID: <58cb370e0511030157l5e47a15h25832fb98e46173a@mail.gmail.com> (raw)
In-Reply-To: <4369D693.4040500@suse.de>

Hi,

>      hw_regs_t hw;
>      memset(&hw, 0, sizeof(hw));
> -    ide_init_hwif_ports(&hw, io, ctl, NULL);
> +    ide_std_init_ports(&hw, io, ctl);

Could you separate this into another patch?

This change fixes ide-cs for some archs but OTOH we should verify that
there are no ide-cs specific hacks in ide_init_hwif_ports() on other archs.

Otherwise patch looks fine.

Thanks,
Bartlomiej

  reply	other threads:[~2005-11-03  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-03  9:21 Hannes Reinecke
2005-11-03  9:57 ` Bartlomiej Zolnierkiewicz [this message]
2005-11-03 10:21   ` Hannes Reinecke
2005-11-03 10:59     ` Bartlomiej Zolnierkiewicz
2005-11-09 21:40     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e0511030157l5e47a15h25832fb98e46173a@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=axboe@suse.de \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®