From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Kasper Sandberg <lkml@metanurb.dk>
Cc: LKML Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] update ide.c to use pci_get_drvdata()
Date: Fri, 18 Nov 2005 23:21:03 +0100 [thread overview]
Message-ID: <58cb370e0511181421jc64f32es7f5b0b710eba20ec@mail.gmail.com> (raw)
In-Reply-To: <1132179131.24326.5.camel@localhost>
[ akpm and linus removed from cc: ]
On 11/16/05, Kasper Sandberg <lkml@metanurb.dk> wrote:
> This updates drivers/ide/ide.c to use pci_get_drvdata() instead of
> accessing driver_data directly.
>
> Signed-off-by: Kasper Sandberg <lkml@metanurb.dk>
diff -Naur linux-2.6.15-rc1-git4-a/drivers/ide/ide.c
linux-2.6.15-rc1-git4-b/drivers/ide/ide.c
--- linux-2.6.15-rc1-git4-a/drivers/ide/ide.c 2005-11-16
22:50:43.700117269 +0100
+++ linux-2.6.15-rc1-git4-b/drivers/ide/ide.c 2005-11-16
23:00:43.891060658 +0100
@@ -1216,7 +1216,7 @@
static int generic_ide_suspend(struct device *dev, pm_message_t state)
{
- ide_drive_t *drive = dev->driver_data;
+ ide_drive_t *drive = pci_get_drvdata(dev);
dev is of "struct device *" type not "struct pci_dev *"
so dev_get_drvdata() should be used instead
struct request rq;
struct request_pm_state rqpm;
ide_task_t args;
@@ -1235,7 +1235,7 @@
static int generic_ide_resume(struct device *dev)
{
- ide_drive_t *drive = dev->driver_data;
+ ide_drive_t *drive = pci_get_drvdata(dev);
ditto
struct request rq;
struct request_pm_state rqpm;
ide_task_t args;
Care to respin the patch?
[ Am I the only one reviewing IDE patches? It seems so... ]
Bartlomiej
prev parent reply other threads:[~2005-11-18 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 22:12 Kasper Sandberg
2005-11-18 22:21 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0511181421jc64f32es7f5b0b710eba20ec@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metanurb.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®