mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@osdl.org>,
	ce@ruault.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] timer-irq-driven soft-watchdog, cleanups
Date: Fri, 17 Feb 2006 23:15:27 +0100	[thread overview]
Message-ID: <58cb370e0602171415q1b040e7er1e7849212f95f2b7@mail.gmail.com> (raw)
In-Reply-To: <20060217201123.GB29025@elte.hu>

On 2/17/06, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > Sorry but I have enough more high priority issues to take care of and
> > I'm not going to spend any more time on soft lockups even if they are
> > really problems in IDE subsystem.  If this is not fixed before 2.6.16
> > I'm submitting patch to Linus making DETECT_SOFTLOCKUP depend on
> > "CONFIG_IDE=n"... at least users will be able to use their systems
> > instead of seeing lockups.
>
> i have lots of IDE based systems (they dont use PIO though) and i'm not
> seeing these. I'll oppose such a patch if it's to hide genuine issues -
> the 10 seconds tolerance is already generous i think. I'll of course fix
> any false positives which are the fault of the softlockup-watchdog, but
> from your mails it appears to me that the IDE warnings are indeed
> genuine.
>
> If the source of the delay is hard to fix you can temporarily work it
> around in the code by putting in the touch_softlockup_watchdog() lines -
> that will also document the places that cause long delays - which is a
> good thing.
>
> It is entirely feasible to put a touch_softlockup_watchdog() call into
> every PIO OP - even a single-byte PIO related IN/OUT instruction takes a
> couple of microseconds, so a touch_softlockup_watchdog() wont even show
> up on the radar.

OK, I'll just add touch_softlockup_watchdog() if needed but first lets
wait for results of your patch.

Note that I'll invest my time on this which could be invested into other
things and I don't see it as top-priority issue if you differ in your opinion
you should be the person fixing affected drivers.

The conclusion of the rant is:  people making changes at higher layers
should start paying maintenance costs of their changes.  Over few years
of maintaining IDE I learned quite a lot about block layer, VFS, VM, ACPI,
PM, IRQ routing, scheduling, sysfs etc (I'm not talking about interface
changes but about bugs/changes which are reported by end users
and driver maintainers are end-point).  This is all good but distracts me
from my primary task and now it is turn for people hacking on generic
code to learn few driver specific things... :)

No wonder that nobody wants to hack drivers: less fame, more flames,
and actually besides knowing hardware you need to know a lot about
kernel in general to do your job right.  I hope that Andrew is reading this.

End of whining.

> > DETECT_SOFTLOCKUP should be an aim in development not a method of
> > forcing driver maintainers to work on specific issues...
>
> well, 10+ seconds delays on a running system are not really acceptable,
> and can cause other problems. The softlockup-watchdog is optional and
> can be easily turned off in the .config.

It is "y" by default so anybody saying "y" to DEBUG_KERNEL will get it as
added bonus and moreover DEBUG_KERNEL is "y" in x86_64 defconfig.

Bartlomiej

  reply	other threads:[~2006-02-17 22:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 18:50 [BUG] kernel 2.6.15.4: soft lockup detected on CPU#0! Charles-Edouard Ruault
2006-02-14 11:41 ` Folkert van Heusden
2006-02-14 16:32   ` Lee Revell
2006-02-15 15:07     ` Folkert van Heusden
2006-02-15 18:19       ` Lee Revell
2006-02-16  1:38         ` Alan Cox
2006-02-17 22:56           ` Lee Revell
2006-02-16  2:51 ` Andrew Morton
2006-02-16  9:44   ` Charles-Edouard Ruault
2006-02-16 10:36     ` Folkert van Heusden
2006-02-16 10:46       ` Andrew Morton
2006-02-16 11:18         ` Charles-Edouard Ruault
2006-02-16 12:57     ` Alan Cox
2006-02-16 13:33   ` Bartlomiej Zolnierkiewicz
2006-02-16 20:20     ` Andrew Morton
2006-02-17 11:47       ` Bartlomiej Zolnierkiewicz
2006-02-17 13:08         ` [patch] timer-irq-driven soft-watchdog, cleanups Ingo Molnar
2006-02-17 14:46           ` Bartlomiej Zolnierkiewicz
2006-02-17 19:52             ` Ingo Molnar
2006-02-17 20:11             ` Ingo Molnar
2006-02-17 22:15               ` Bartlomiej Zolnierkiewicz [this message]
2006-03-13 14:48                 ` Charles-Edouard Ruault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e0602171415q1b040e7er1e7849212f95f2b7@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@osdl.org \
    --cc=ce@ruault.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®