From: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
To: "Richard Purdie" <rpurdie@rpsys.net>
Cc: "Andrew Morton" <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH -mm 4/4] LED: Add IDE disk activity LED trigger
Date: Wed, 29 Mar 2006 09:18:25 +0200 [thread overview]
Message-ID: <58cb370e0603282318t1b74c40cx6a173b3561c3fa54@mail.gmail.com> (raw)
In-Reply-To: <1143591445.14682.60.camel@localhost.localdomain>
On 3/29/06, Richard Purdie <rpurdie@rpsys.net> wrote:
> Add an LED trigger for IDE disk activity to the ide-disk driver.
>
> Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
>
> Index: linux-2.6.16/drivers/ide/ide-disk.c
> ===================================================================
> --- linux-2.6.16.orig/drivers/ide/ide-disk.c 2006-03-28 17:22:51.000000000 +0100
> +++ linux-2.6.16/drivers/ide/ide-disk.c 2006-03-28 17:25:12.000000000 +0100
> @@ -60,6 +60,7 @@
> #include <linux/genhd.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> +#include <linux/leds.h>
>
> #define _IDE_DISK
>
> @@ -316,6 +317,8 @@
> return ide_stopped;
> }
>
> + ledtrig_ide_activity();
> +
Now this is really non-intrusive. :)
Thank you for reworking the patch.
The rest of changes also look fine for me, ACK.
Bartlomiej
prev parent reply other threads:[~2006-03-29 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-29 0:17 Richard Purdie
2006-03-29 7:18 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0603282318t1b74c40cx6a173b3561c3fa54@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®