From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758396AbWK2WGm (ORCPT ); Wed, 29 Nov 2006 17:06:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758362AbWK2WGD (ORCPT ); Wed, 29 Nov 2006 17:06:03 -0500 Received: from nf-out-0910.google.com ([64.233.182.186]:61826 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1758371AbWK2WF7 (ORCPT ); Wed, 29 Nov 2006 17:05:59 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jrzv22iOvw5wVQsJ7fZpyszwgWf8pvSN1C8gHBfxUYD/FVKKQLJcs922A86FhM7HF3aXpAXojBWQPVW1QXFxQcdyHSWs3LI9KcgMm/ifkU4l4CKwuCQXrToRpb4+VG5RwjQbRlG1sh3BTP5Dg0mg+OKgv+Lhc7JwwMCMXiZN3Jo= Message-ID: <58cb370e0611291405j1e5f3eb1t4950ed0993b84c85@mail.gmail.com> Date: Wed, 29 Nov 2006 23:05:56 +0100 From: "Bartlomiej Zolnierkiewicz" To: Alan Subject: Re: [PATCH] ide_scsi: allow it to be used for non CD only Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, akpm@osdl.org In-Reply-To: <20061129144652.299f7919@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061129144652.299f7919@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, Nowadays, you can dynamically change driver bound to a device using sysfs and it works just fine for IDE, ie: echo -n "1.0" > /sys/bus/ide/drivers/ide-scsi/unbind echo -n "1.0" > /sys/bus/ide/drivers/ide-cdrom/bind to unbind /dev/hdc from ide-scsi and bind to ide-cdrom That was one of the main goals behind my old patches to convert IDE device drivers to device-model. Please don't add another module parameter for controlling driver binding and making it more complicated than already is: * "hdx=scsi" kernel parameter * "hdx=driver" kernel parameter * /proc/ide/hd?/driver interface * ide_cd and "ignore" parameter (actually all the above can go away). Bart On 11/29/06, Alan wrote: > Some people want to use ide_cd for CD-ROM but still dynamically load > ide-scsi for things like tape drives. If you compile in the CD driver > this works out but if you want them modular you need an option to ensure > that whoever loads first the right things happen. > > This replaces the original draft patch which leaked a scsi host reference > > Signed-off-by: Alan Cox > > diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.19-rc6-mm1/drivers/scsi/ide-scsi.c linux-2.6.19-rc6-mm1/drivers/scsi/ide-scsi.c > --- linux.vanilla-2.6.19-rc6-mm1/drivers/scsi/ide-scsi.c 2006-11-24 13:58:08.000000000 +0000 > +++ linux-2.6.19-rc6-mm1/drivers/scsi/ide-scsi.c 2006-11-29 14:18:12.000000000 +0000 > @@ -110,6 +110,7 @@ > } idescsi_scsi_t; > > static DEFINE_MUTEX(idescsi_ref_mutex); > +static int idescsi_nocd; /* Set by module param to skip cd */ > > #define ide_scsi_g(disk) \ > container_of((disk)->private_data, struct ide_scsi_obj, driver) > @@ -1127,11 +1128,14 @@ > warned = 1; > } > > + if (idescsi_nocd && drive->media == ide_cdrom) > + return -ENODEV; > + > if (!strstr("ide-scsi", drive->driver_req) || > !drive->present || > drive->media == ide_disk || > !(host = scsi_host_alloc(&idescsi_template,sizeof(idescsi_scsi_t)))) > return -ENODEV; > > g = alloc_disk(1 << PARTN_BITS); > if (!g) > @@ -1187,6 +1192,7 @@ > driver_unregister(&idescsi_driver.gen_driver); > } > > +module_param(idescsi_nocd, int, 0600); > module_init(init_idescsi_module); > module_exit(exit_idescsi_module); > MODULE_LICENSE("GPL");