From: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>,
akpm@osdl.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver
Date: Wed, 13 Dec 2006 02:09:42 +0100 [thread overview]
Message-ID: <58cb370e0612121709x41270fb2p20280cc1edc9c533@mail.gmail.com> (raw)
In-Reply-To: <20061212234145.557cb035@localhost.localdomain>
On 12/13/06, Alan <alan@lxorguk.ukuu.org.uk> wrote:
> > +static int tc86c001_busproc(ide_drive_t *drive, int state)
> > +{
>
> Waste of space having a busproc routine. The maintainer removed all the
> usable hotplug support from old IDE so this might as well be dropped.
I took over IDE when hotplug was already broken (late 2.5), moreover IDE
hotplug support has been always a quick hack according to its original author...
I remember your great efforts to fix it but unfortunately they
depended on executing
ioctls on non-existing devices which made them depend on layering
violation in 2.6,
also IDE device model fixes has some conflicts with them. I take the
blame for not
applying them (for the reasons given above) and for taking much too
long in reviewing/testing them (due to lack of time not bad intention)
but accusing me of
intentional feature removal is going a bit too far... You can hate me
all you want
for the way I did my entirely volunteer and unpaid job (but hey there
were and still is shortage of ATA hackers and there weren't anybody to
step up and takeover IDE)
but I actually have always taken responsibility/blame for all my
patches and patches
I accepted so if you really think I intentionally removed some usable
hotplug support
please point me to specific patch and describe the regression after
applying this
specific patch and I will do my best to have this regression fixed...
Bart
next prev parent reply other threads:[~2006-12-13 1:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 22:48 Sergei Shtylyov
2006-12-12 22:57 ` Sergei Shtylyov
2006-12-12 23:00 ` Randy Dunlap
2006-12-12 23:07 ` Sergei Shtylyov
2006-12-12 23:12 ` Randy Dunlap
2006-12-12 23:41 ` Alan
2006-12-13 1:09 ` Bartlomiej Zolnierkiewicz [this message]
2006-12-13 11:32 ` Alan
2006-12-13 14:01 ` Bartlomiej Zolnierkiewicz
2006-12-13 14:16 ` Alan
2006-12-13 14:19 ` Bartlomiej Zolnierkiewicz
2006-12-13 14:16 ` Sergei Shtylyov
2006-12-13 14:53 ` Alan
2006-12-13 0:40 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0612121709x41270fb2p20280cc1edc9c533@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®