From: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>
To: "Conke Hu" <conke.hu@gmail.com>
Cc: "Linux kernel mailing list" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@osdl.org>, "Greg KH" <greg@kroah.com>
Subject: Re: [PATCH 1/3] atiixp.c: remove unused code
Date: Sun, 7 Jan 2007 03:12:59 +0100 [thread overview]
Message-ID: <58cb370e0701061812s49c4b1f5p5c5e99e5eea3bb89@mail.gmail.com> (raw)
In-Reply-To: <5767b9100701060411h13324086uf6552a5166641534@mail.gmail.com>
On 1/6/07, Conke Hu <conke.hu@gmail.com> wrote:
> A previous patch to atiixp.c was removed but some code has not been
This one?
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab17443a3df35abe4b7529e83511a591aa7384f3
Doesn't it break existing setups without giving ANY warning?
theoretical (I don't have hardware in question) scenario:
- user uses atiixp and has modular libata/ahci (or no libata/ahci et all)
- user does kernel upgrade
- boot fails
- ...
If this is true please add something like
printk(KERN_WARNING "PCI: setting SB600 SATA to AHCI mode"
" (please use ahci driver instead of atiixp)\n");
to quirk_sb600_sata() so people will at least know what is wrong...
> cleaned. Now we remove these code sine they are no use any longer.
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
[ but the patch is line wrapped and unfortunately doesn't apply ]
PS: please always cc: linux-ide@vger.kernel.org on PATA/SATA patches
Thanks,
Bart
next prev parent reply other threads:[~2007-01-07 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 12:11 Conke Hu
2007-01-07 2:12 ` Bartlomiej Zolnierkiewicz [this message]
2007-01-09 11:28 ` Conke Hu
2007-01-09 14:10 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0701061812s49c4b1f5p5c5e99e5eea3bb89@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@osdl.org \
--cc=conke.hu@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®