From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC8B1DE4D5 for ; Mon, 13 Jan 2025 22:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736806355; cv=none; b=hJz+ntGAfaXoHC18EY6H81XpU7Vaq5bbRASb3EL9W+CJg+MOznS08oL2xiSJADWtnbZNjb55xYg5VHYpqPagkpWfEaUkJrxIwAdkDBiqGRcPSxQGS8zYOky1apEvthRmWQivTaakGfGTOoMu+uuXyHUU5CT9dzL0JSRUK5Grakc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736806355; c=relaxed/simple; bh=yVcj7I5OZjRQqDaKuobDa4won/Grb8xO1wafl58Rj0A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TtGJjmy8ZSPI43Dttv8i/tdab9HudLc5xltd77YrbqKcs/4bZEbl9UIfLMbhuHGDw3Wpy6yy1odCYtl9BgYL3SDj6tJQH23F4JfXMcLU4S0IazJfhln2Cjaa5e+8C6hbFVaX5nCJ4f1SCDyDkAv2LtakWS+p/yryCtNihEiusGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iGSybc1h; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iGSybc1h" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aaf0f1adef8so1004002666b.3 for ; Mon, 13 Jan 2025 14:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736806352; x=1737411152; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=9qh/KNveqcXCTBcx72ejlKl8SrMCLTgKOABRLWwoibo=; b=iGSybc1h1AyO8m7oILc23h+1LnW5KWUG8PN1soR1zVHknsv7tKqklL+U+b1vFDAt9o FfQGOvcEAgfAVqkbEO7PIqCYIlbQ5fUAJ3ST2Hw+KOlQJvCzs2dtioPvkojqWjXHCXQW RRUfGdKiR9tzxuhtx8nGwZRkbLHSQdfQTtjIFHv75kCEBM47RBTmXbPTnVag0/qcCcjt /774FdoI8umCkOdbUGAW4TNSHCIUBsXT8GE0NGqrdwAUyFraFfNFKsooEQaKuVG2F4U5 XpSR5T2FZJHp64XqRrSFfDpQr91kfKj5uDAuwtZp3qcJa91UsT4bwYJGhV7P7CTnReeN vtDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736806352; x=1737411152; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9qh/KNveqcXCTBcx72ejlKl8SrMCLTgKOABRLWwoibo=; b=kjxqSrQkTmerBMaiZdsm8XtZOUOXLKWFicm24FweKQV/crLc28HOzOeDGpAowlkUGA isRZhcFGoB82QY9MyTcpAqoYRUl3VzotSWuVIPH4weULQFtUNIRfYaLOVCy3eP/cheoL 01XUHF9YTXXJTrxcHbAZrs6dTpGnISE67Hrw2sINayO/rR0e2/pCjJTfoAAXinLleRwq GfQ38ULwGT46pkoCkYXhAX8tFLzkQcAqz9Q+JYvpdY2i5BCyGRupVKgIyrIMAdUd64nh mSxZjlOrNUFabV5vZXHhUX1KUYo1GOAmG/6J7eblCN0D8HAhqYLG1HQnalIY/40r6kEr 3Ueg== X-Forwarded-Encrypted: i=1; AJvYcCU6U7cf8k9qGTPvaip03LHWO6p+N2rGUkeeW/2TyrPU77BKkHRBBgbyyIRYmFpTfUiqA5lbd8Q/GGfggao=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5HZ2Z3dLUsB19HeIFcpSXJgmKmNuVRe5O3TyzXiJqKlU1ZkuJ N5oLZx9uCNUImk4hVpkaHhSSyC1b3udrlgp2/lvHFSETjh33i2+2 X-Gm-Gg: ASbGncv66IqoO40FmoY6XBixikCC7I92ddULePDe4YHFvryJIsomG1if3BgCJHS/d61 TIeKRCNtnQLewiVyARieDfZ7Z0S51cPQzEfFxjXxDYSV5JKwGjuwRLb4lkvyz5//tDnI7hSiCOD j9XDZgcs5Pmry/UCnqdsDcGqMT2KXZZcCwWZhqcDq4PykxalFDFeQxk0MvrO9ePYTr3CaiXfJvN IHbpyu5oKfRwBdkNqit4x9B0tjsJJHihgb9ccZufY4j4y5FRg006cPnHlUoMZlkVNVcBKHZWJEI mBoCs+/GhVb7Gm0PKsrpx8s88w== X-Google-Smtp-Source: AGHT+IHraRU0fZq8qzdn794Qp1Qzg4oJLAsv5qU3CaW6U+DO/jzYcbOZOZk0YmFmaDgLKgj2EPIXJw== X-Received: by 2002:a17:907:2da6:b0:aac:2297:377d with SMTP id a640c23a62f3a-ab2abdc09eemr2144577466b.52.1736806351505; Mon, 13 Jan 2025 14:12:31 -0800 (PST) Received: from ?IPV6:2a00:f41:cfe:29b3:7412:fabe:3e5d:365? ([2a00:f41:cfe:29b3:7412:fabe:3e5d:365]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9649939sm545070066b.182.2025.01.13.14.12.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 14:12:31 -0800 (PST) Message-ID: <58cb6c37-0ea0-4866-a2b1-92cb0f0391a7@gmail.com> Date: Mon, 13 Jan 2025 23:12:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage To: Stephen Boyd , AngeloGioacchino Del Regno , Joe Hattori , Konrad Dybcio , Matthias Brugger , Mauro Carvalho Chehab Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Johan Hovold , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Konrad Dybcio References: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com> <5b139af8d639e20a14c8bd00e8e03a4a.sboyd@kernel.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konradybcio@gmail.com; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzSVLb25yYWQgRHli Y2lvIDxrb25yYWR5YmNpb0BnbWFpbC5jb20+wsGRBBMBCAA7AhsDBQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAFiEEU24if9oCL2zdAAQVR4cBcg5dfFgFAmQ5btACGQEACgkQR4cBcg5dfFhw JBAAp7+SFJq0oGQ21dulLrJZx1s1RfNi35SKegi+ueLOezipsfD9s2weu37/xE+PQ9ONDm39 Uq+plABz8grTgy19N5RZnY2gQNcN335fQWq31wk6OEhr3E04hBx94eejKI9ynXJUXOddwjCm blrqUnAhWCq0lM2Dsj1d1qUKF2wSTiQW4aNkc6izUgmGuY26WNfD52T5RHvGi8XtCNAKI1yK cCTmRY0zXIdR3bp+FnJHetjwy1ScbDiruhnaad31plRy4a+CxNeplUjWecufnWYCR3xFypNE TZm+z23CgUVmYQPNZZGO4h0SaRxnHhsewtlC9+DSaKm+7RzfbNbGRg6kxL2YG9PEqA64LAQI Vl0zkuF8xyGFcPioJ5Bg9UaN8M81xPuPwrN+Sb/PXgC/RKQ59hXI6fNAHoP9XwAAus5j0oRg BJb/+pXX9PQGtmIKJMp9l337VuCkXk/iaZ6HNWDumdeiUDA7m3vUHWVvsF5Xna+suUOSXPZ9 kwlbfHvfFpbuqr/VNN6qRpipx0vSvuDo5Ar4PoCuNDcHkmSlxMqqp8GG9oDi4cnl0XzirQpQ /rve1X50GUA7nVNagxQzvjRyZlcldVKHNIQXOR+XqEAwIGLRwqYo+iUOBZXFKHAS5EFooBJj 7QuEwSEWg7QYvOdXZOcmZGzGQa0Iq22KJgddx+DOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <5b139af8d639e20a14c8bd00e8e03a4a.sboyd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/13/25 22:52, Stephen Boyd wrote: > Quoting Konrad Dybcio (2025-01-13 05:02:58) >> From: Konrad Dybcio >> >> On some platforms, like recent Qualcomm SoCs with multi-bus SPMI >> arbiters, controller->node must be assigned to the individual buses' >> subnodes, as the slave devices are children of these, like so: >> >> arbiter@c400000 >> spmi@c42d000 >> pmic@0 >> >> spmi@c432000 >> pmic@0 >> >> The commit referenced in Fixes changed that assignment, such that >> spmi_controller_alloc() always assumes the PMICs come directly under >> the arbiter node (which is true when there's only a single bus per >> controller). >> >> Make controller->node specifiable to both benefit from Joe's refcount >> improvements and un-break the aforementioned platforms. > > How is it broken? I see spmi_pmic_arb_bus_init() calls > devm_spmi_controller_alloc() which sets the of_node to the parent device > and then spmi_pmic_arb_bus_init() overwrites that with > 'ctrl->dev.of_node = node' later on in the same function. That will > cause one more of_node_put() than is expected. I don't see that removed > in this patch though, so the leak is still there? > >> >> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup") > > I've dropped this patch from my queue. I don't know if we're really > doing anything better by managing the of_node lifetime in that function > vs. letting the callers assign the node they want and manage the > lifetime themselves. Maybe we don't need to do anything? Presumably the > parent device driver will unregister the controller anyway, so the > lifetime of the of_node will be ensured regardless. For subnodes like > qcom SPMI, the subnodes are child nodes of the parent device so they > won't be removed. If they are dynamic nodes, then the caller can manage > the lifetime. Stephen, the wrong node gets assigned in the qcom driver with multi-master controllers, resulting in probe failures. Since the introduction of the commit referenced in fixes, of_spmi_register_devices() sees the controller's subnodes (which describe each of the two masters) as slave devices - meaning no "real" devices ever get to probe Konrad